Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mechanism to allow linking anchors for XMI defined objects that are not generated in document #70

Open
ronaldtse opened this issue Sep 13, 2021 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@ronaldtse
Copy link
Contributor

From metanorma/ogc-citygml-xmi#110

In the CityGML 3.0 XMI file, the following classes are used (by other classes) but not defined because they are out of scope:

Area
Boolean
Character
CharacterString
Date
DateTime
EngineeringCRS
GenericName
Integer
Length
Measure
Real
ScopedName
TM_Duration
URI
UnitOfMeasure
Volume

However, the plugin today creates links to these anchors but they are not present in the current document:

Area-section
Boolean-section
Character-section
CharacterString-section
Date-section
DateTime-section
EngineeringCRS-section
GenericName-section
Integer-section
Length-section
Measure-section
Real-section
ScopedName-section
TM_Duration-section
URI-section
UnitOfMeasure-section
Volume-section

This means we need to have a YAML configuration that "defines where the classes that are out of scope should link to", e.g.

packages:
  - "Core"
  - "Appearance"
external_classes:
  - "Area": {{Area}}
  - "Boolean": my-section-for-boolean
  - ...
section_depth: 3
render_style: data_dictionary
include_root: true
@ronaldtse
Copy link
Contributor Author

From @w00lf

I have implemented #70, tried to implement it for metanorma/ogc-citygml-xmi#101 issue but now i see that sections were changed to the new lutaml format, eg:

term-URI => URI-section

Should i create a PR with the old mappings and return old refs?

Yes. The anchors in this commit (metanorma/ogc-citygml-xmi@bcc7cf7) should be removed and replaced with the new functionality. Thanks!

@w00lf
Copy link
Contributor

w00lf commented Sep 20, 2021

@ronaldtse used new logic in metanorma/ogc-citygml-xmi#122

@w00lf
Copy link
Contributor

w00lf commented Oct 13, 2021

This was implemented in #73 and implemented in metanorma/ogc-citygml-xmi#122. @ronaldtse can we close this one?

@ronaldtse ronaldtse moved this to Triage in Metanorma Nov 14, 2021
@ronaldtse
Copy link
Contributor Author

@w00lf this is not fixed because the exceptions are manually encoded. We need an automatic solution where LutaML detects which models are not defined in the document, and does not create those links.

@ronaldtse ronaldtse assigned suleman-uzair and unassigned w00lf Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🆕 New
Development

No branches or pull requests

3 participants