Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent or missing French filename #33

Open
andrew2net opened this issue Dec 16, 2024 · 11 comments
Open

Inconsistent or missing French filename #33

andrew2net opened this issue Dec 16, 2024 · 11 comments
Assignees

Comments

@andrew2net
Copy link
Contributor

The English and French versions of the documents are placed in separate folders, meetings-en and meetings-fr, respectively.
For the file jcrb/meetings-en/meeting-48.yml there is no corresponding French version in the jcrb/meetings-fr folder.
There is a French file with a year in its filename jcrb/meetings-fr/meeting-482024.yml but it misses resolutions. Is this a French version of jcrb/meetings-en/meeting-48.yml?

@ronaldtse
Copy link
Contributor

@andrew2net can you also ping @jmilesBIPM at the BIPM so her colleagues could fix any missing pages?

@jmilesBIPM is this something your team could address? Thanks! (Perhaps Celine or Laurent would also have GitHub accounts?)

@ronaldtse
Copy link
Contributor

@andrew2net is this a general problem for all JCRB meetings, or is this only for Meeting 48?

This problem is not affecting the SI Brochure, right? Because this only concerns JCRB Meeting 48?

@andrew2net
Copy link
Contributor Author

@andrew2net is this a general problem for all JCRB meetings, or is this only for Meeting 48?

It's only for Meeting 48

This problem is not affecting the SI Brochure, right? Because this only concerns JCRB Meeting 48?

It's affecting the relaton-data-bipm because the repo contains documents from the 3 sources (outcomes, rawbib, and SI Brochure). To update the BIPM dataset the relaton-data-bipm's GHA removes all docs, then fetches new docs from all the 3 sources. If one of the fetching fails, nothing is committed.

@ronaldtse
Copy link
Contributor

@andrew2net so how can we fix this issue? We have to handle this asap.

@andrew2net
Copy link
Contributor Author

@ronaldtse we can ignore if a corresponding French file doesn't exist currently. I'll add auto-creating GH issues functionality later.

@ronaldtse
Copy link
Contributor

OK let's do that. The key point is to fix the issues first so the BIPM can publish before the deadline!

andrew2net added a commit to relaton/relaton-bipm that referenced this issue Dec 17, 2024
@andrew2net
Copy link
Contributor Author

andrew2net added a commit to relaton/relaton-bipm that referenced this issue Dec 19, 2024
@ronaldtse
Copy link
Contributor

@andrew2net can we close this now? Thanks.

@andrew2net
Copy link
Contributor Author

@andrew2net can we close this now? Thanks.

@ronaldtse I don't think so, nothing has changed. Relaton just ignores missing respective files. It seems the file jcrb/meetings-fr/meeting-482024.yml should be renamed to jcrb/meetings-fr/meeting-48.yml. The file also misses resolutions.

@ronaldtse
Copy link
Contributor

@andrew2net then can you file the issue at bipm-data-importer for @hmdne ?

According to the URL specified in the file, there are indeed no resolutions listed on that web page. So it is correct not to have resolutions.

@andrew2net
Copy link
Contributor Author

@ronaldtse done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants