attach() doesn't trigger a poll

[alexstrat]

I noticed that, when attaching to a session, if there is no activity (send stanza) Strophe never polls.. and the session expires after a while whereas I'm attached..

When using #connect, Strophe polls at least every 60 seconds. When attached, should we not have the same behavior ?

I don't know if this should be fixed but I think I have the fix, which is not hard. Actually, the _onIdle process is not triggered because we are disconnected, it shall be restarted by hand : In #attach(), #_onIdle() shall be called at the end.

 attach: function (jid, sid, rid, callback, wait, hold, wind)
    {
       //...
       //Bla bala
       //...

        this._changeConnectStatus(Strophe.Status.ATTACHED, null);
        this._onIdle();
    },

I'll do a pull request if you find this relevant. Thanks.

[Marko-M]

I had to place _onIdle() before this._changeConnectStatus because my attach() callback is being triggered there. If I place it at the end like you propose first stanza from my callback receives no response because there is no polling. Are we doing something wrong or is this an issue?

 attach: function (jid, sid, rid, callback, wait, hold, wind)
    {
       //...
       //Bla bala
       //...
        this._onIdle();
        this._changeConnectStatus(Strophe.Status.ATTACHED, null);
    },

[bodhi]

I've had the same problem. It seems it that attach() should call flush() before _changeConnectStatus(). This triggers the call to _onIdle(), and doesn't stomp on any existing timeouts configured. A workaround for it is to call flush() in the callback you pass to attach():

connection = new Strophe.Connection(host);
onAttach = function(status) {
  connection.flush();
  // do whatever else you need to do when connecting
};

connection.attach(jid, rid, sid, onAttach);