Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many typos on Basic concepts of flexbox page #37475

Closed
Hexstream opened this issue Jan 2, 2025 · 4 comments · Fixed by #37498
Closed

Many typos on Basic concepts of flexbox page #37475

Hexstream opened this issue Jan 2, 2025 · 4 comments · Fixed by #37498
Labels
accepting PR Feel free to open a PR to resolve this issue Content:CSS Cascading Style Sheets docs

Comments

@Hexstream
Copy link

Hexstream commented Jan 2, 2025

MDN URL

https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_flexible_box_layout/Basic_concepts_of_flexbox

What specific section or headline is this issue about?

Various, see below.

What information was incorrect, unhelpful, or incomplete?

Multi-line flex containers with flex-wrap

"and they" does not make sense:

If you set it to nowrap, which is the initial value, and they will shrink to fit the container.

This should probably be (just remove "and"):

If you set it to nowrap, which is the initial value, they will shrink to fit the container.

Properties applied to flex items

"distribute" should be "distributed":

The flex properties that we apply to the items themselves, enable dictating how that available space should be distribute among the sibling flex items.

Shorthand values for the flex properties

"of for" does not make sense:

Setting flex: initial resets the item to the initial values of for the three longhand properties, which is the same as flex: 0 1 auto.

Removing either word would probably work, I'm not sure which wording is more prevalent in MDN documentation.

Setting flex: initial resets the item to the initial values of the three longhand properties, which is the same as flex: 0 1 auto.

Setting flex: initial resets the item to the initial values for the three longhand properties, which is the same as flex: 0 1 auto.

Shorthand values for the flex properties

This is the same as writing flex: 1 1 0 or flex: 2 1 0 and so on, respectively. The items can grow and shrink from a flex-basis of 0.

Can the items really shrink from a flex-basis of 0? This seems confusing at best.

align-items

"align" should be "aligns":

The align-items property align all the flex items on the cross axis.

place-items and place-content

"and" doesn't seem like the best word here:

If set on a flex container, it will set the alignment but not the justification, and justify-items is ignored in flexbox.

I would suggest "as" or "since":

If set on a flex container, it will set the alignment but not the justification, as justify-items is ignored in flexbox.

If set on a flex container, it will set the alignment but not the justification, since justify-items is ignored in flexbox.

What did you expect to see?

No typos.

Do you have any supporting links, references, or citations?

No response

Do you have anything more you want to share?

No response

MDN metadata

Page report details
@Hexstream Hexstream added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jan 2, 2025
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Jan 2, 2025
@OnkarRuikar
Copy link
Contributor

@Hexstream could you submit a pull request to fix the page content?

@Hexstream
Copy link
Author

Sorry, I'm too busy to onboard myself for that kind of contribution, as previously said.

@bsmth bsmth added accepting PR Feel free to open a PR to resolve this issue and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Jan 3, 2025
@mohammednumaan
Copy link
Contributor

mohammednumaan commented Jan 4, 2025

Hey @Hexstream, I'm currently working on this issue and I wanted to clarify something.

Can the items really shrink from a flex-basis of 0? This seems confusing at best.

It could possibly shrink if there is some content within the container, since it would initialize it to that particular width. But this can cause confusion when there is no content within the flex-container (which in most cases is unlikely). What improvements do you think I can include here to avoid confusion?

@Hexstream
Copy link
Author

Hexstream commented Jan 4, 2025

Thank you for raising the question!

Unfortunately, I am not yet clear on the details of what a flex-basis of 0 really means,
so I feel someone who does should help elucidate the question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepting PR Feel free to open a PR to resolve this issue Content:CSS Cascading Style Sheets docs
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants