Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type hints to code #27

Open
mtbc opened this issue Dec 9, 2021 · 2 comments
Open

Add type hints to code #27

mtbc opened this issue Dec 9, 2021 · 2 comments

Comments

@mtbc
Copy link
Collaborator

mtbc commented Dec 9, 2021

It would make sense to add at least some level of type hinting to our code, especially starting while the project is young. CI could then use Mypy.
@mtbc
Copy link
Collaborator Author

mtbc commented Dec 9, 2021 •
edited
Loading

I am holding off for now because numpy 1.21 offers NDArray and, from my MCViNE environment, if I conda install numpy=1.21 then I get numpy 1.20.3.

@mtbc
Copy link
Collaborator Author

mtbc commented Dec 16, 2021

Possibly also worth waiting for numpy/numpy#16544 before putting effort in here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mtbc