Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue on Laravel 5 - potential deprecated call to createMatcher #9

Open
mattglover11 opened this issue Jun 12, 2015 · 4 comments
Open

Comments

@mattglover11
Copy link

Call to undefined method Illuminate\View\Compilers\BladeCompiler::createMatcher()

This occurs immediately after installation.

@mattglover11
Copy link
Author

In PotionServiceProvider, I have confirmed the use of the (apparently) depricated createMatcher.

Needs to be:
/*
* If the directive method exists, we're using Laravel 5
*/
if (method_exists($compiler, 'directive')) {
// do something
}
else {
$pattern = $compiler->createMatcher('potion_asset_url');
}

@mattglover11
Copy link
Author

I've forked your repo so I can keep developing. Let me know if an existing dev is onto this otherwise I'll submit a PR.

@mattglover11
Copy link
Author

Guys - I've written the following code to handle the L5.1+ codebase. SparkEleven@c000e6b

I really need confirmation that I've correctly understood why you were using BladeCompiler::createMatcher in the first place as the pattern seems simple.

@mattrmiller
Copy link
Owner

Thank you for your contribution, if you create a patch request I can merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants