Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font picker background does not respect dark mode #344

Open
yvvki opened this issue Aug 29, 2024 · 1 comment
Open

Font picker background does not respect dark mode #344

yvvki opened this issue Aug 29, 2024 · 1 comment

Comments

@yvvki
Copy link

yvvki commented Aug 29, 2024

When picking fonts at the website version of Material Theme Builder, the background does not change with the browser theme.

This is the default view of the picker when viewed as is on a browser with a light theme:
image

However, upon changing to a dark theme (regardless the website dark/light mode), the background remains the same while the text becomes its dark variant:
image

Expected behavior
The background should change into their dark variant to accommodate the light text, in which are currently have poor visibility due to its low contrast.

Additional context
It's worth to recap that this issue happened due to the browser theme, not the website dark/light mode. In browser like Mozilla Firefox, these is the example theme to reproduce this issue:
image

@rbalet
Copy link

rbalet commented Oct 1, 2024

Happen also on

OS: iOS
Browser Chrome
Version 129.0.6668.70 (Official Build) (arm64)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants