Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Either delete or merge the audit_exceptions branch #46

Open
rgoldberg opened this issue Nov 7, 2024 · 1 comment
Open

Either delete or merge the audit_exceptions branch #46

rgoldberg opened this issue Nov 7, 2024 · 1 comment

Comments

@rgoldberg
Copy link
Contributor

rgoldberg commented Nov 7, 2024 •
edited
Loading

Either delete or merge the audit_exceptions branch.
@rgoldberg rgoldberg changed the title Delete all existing branches other than main in the repo Either delete or merge the audit_exceptions branch Nov 21, 2024
@rgoldberg
Copy link
Contributor Author

@phatblat Now that I've looked into the branch, it looks like it allows the custom tap mas formula to pass an audit even if the version is a prerelease, which will allow us to bump the custom tap mas formula to a prerelease without disabling the audit check.

This seems useful without any negatives, so I think we should merge it into main.

If I don't hear back from you by Tuesday the 26th, I'll assume it's fine to merge it into main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phatblat @rgoldberg