Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shorter bin install commands #170

Closed
wants to merge 1 commit into from

Conversation

dfang
Copy link

@dfang dfang commented Aug 7, 2023

close #171

@dfang dfang marked this pull request as ready for review August 7, 2023 16:29
@marcosnils
Copy link
Owner

hey! thx for the contribution! Your PR gave me an idea. How about if we add a new command like bin alias to add or remove those aliases that can be stored in bin's config?

We could include the shorthands that you're proposing here as a default during config init or maybe through bin alias add --default to populate them.

Thoughts?

@dfang
Copy link
Author

dfang commented Aug 7, 2023

bin alias is good, but it should not be the top priority thing. as people can contribute to this file.

I think for the moment smart choose is more important. I mean for this case, 3 should be chosen. I noticed there are issues out on the list.

λ bin i dandavison/delta
   • Getting latest release for dandavison/delta
   • Starting download of https://api.github.com/repos/dandavison/delta/releases/assets/111116981
2.53 MiB / 2.53 MiB [---------------------------------------------------------------------------------] 100.00% 122.77 KiB p/s 22s

Multiple matches found, please select one:

 [1] delta-0.16.5-x86_64-apple-darwin/LICENSE
 [2] delta-0.16.5-x86_64-apple-darwin/README.md
 [3] delta-0.16.5-x86_64-apple-darwin/delta
 Select an option:

@marcosnils
Copy link
Owner

bin alias is good, but it should not be the top priority thing. as people can contribute to this file.

I agree... but I think moving that file shorthands to the bin config even without the bin alias command would be something very useful as users will be able to add / remove shorthands by manually editing the config file. WDYT?

I think for the moment smart choose is more important. I mean for this case, 3 should be chosen. I noticed there are issues out on the list.

yes, agree. I have some ideas on how to improve this, just need to find the time to try them out.

@dfang
Copy link
Author

dfang commented Aug 7, 2023

bin alias is good, but it should not be the top priority thing. as people can contribute to this file.

I agree... but I think moving that file shorthands to the bin config even without the bin alias command would be something very useful as users will be able to add / remove shorthands by manually editing the config file. WDYT?

it helps ...

@marcosnils
Copy link
Owner

it helps ...

would you be interested in making this refactor? I can tackle whenever I find some bandwidth though.

@dfang
Copy link
Author

dfang commented Aug 11, 2023

I think from the perspective of keeping it simple it's not necessary, with this PR, the most widely used tools should be covered, and the else could be installed by bin i <USER>/<REPO>. this could make config file simple.

@marcosnils
Copy link
Owner

👍. I'll refactor when I find the time. In the meantime I'll hold this PR since I don't want to hardcode custom shorthands in the code that will require a new release every time someone wants to add a new one.

@dfang
Copy link
Author

dfang commented Aug 13, 2023

Can you enable the discussions feature for this repo?

@marcosnils
Copy link
Owner

Sure, done

@dfang
Copy link
Author

dfang commented Aug 13, 2023

@marcosnils thanks, #172

@marcosnils
Copy link
Owner

closing since this didn't get too much traction and it has been stale for a while

@marcosnils marcosnils closed this Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shorter bin install command
2 participants