Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex matching for package_path #161

Open
mbainter opened this issue Mar 9, 2023 · 2 comments
Open

Regex matching for package_path #161

mbainter opened this issue Mar 9, 2023 · 2 comments

Comments

@mbainter
Copy link

mbainter commented Mar 9, 2023

(Feature Request)
A number of packages use the version number within the package, either as part of the initial directory or in the binary itself (which has come up before in #135).

it would be a nice addition to be able to use a regex for the package path, even if you had to edit the JSON by hand for the time being. As an initial implementation, it could simply require it only to match one file, and if it matches more than one error out.

This would help deal with these edge-cases in the short term.

@marcosnils
Copy link
Owner

@mbainter I was thinking in a feature without having to actually make the user set a regex matching. Do you have an example of a package that's currently triggering this for you?

@mbainter
Copy link
Author

mbainter commented Mar 9, 2023

I thought you were, but - that is definitely a more complex solution to undertake, with a large potential for irritating edge cases. If nothing else, an mvp like this might help to establish what such a solution would need to look like. You could potentially even automate that, with a submission subcommand of some kind to send example packages and the regex people are using to some endpoint to see how big a task that will be.

In my case, I think I'm mostly hitting it in orhun/systeroid and orhun/systeroid-tui which has a tarball structured as <package>-<version>/<binary> (i.e. systeroid-0.3.1/systeroid)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants