-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Links purchased separately default to true when importing downloadable products #38465
Comments
Hi @xtremevision. Thank you for your report.
Join Magento Community Engineering Slack and ask your questions in #github channel. |
@magento give me 2.4-develop instance |
Hi @xtremevision. Thank you for your request. I'm working on Magento instance for you. |
Hi @xtremevision, here is your Magento Instance: https://22fd3af061b718c51d99196ae479a3ea.instances-prod.magento-community.engineering |
How do I upload the file for the link to the develop instance? Or what url can I use for the link (instead of file) that will be allowed by env.php? |
Hi @engcom-Bravo. Thank you for working on this issue.
|
Hi @engcom-Dash. Thank you for working on this issue.
|
✅ Jira issue https://jira.corp.adobe.com/browse/AC-11409 is successfully created for this GitHub issue. |
✅ Confirmed by @engcom-Dash. Thank you for verifying the issue. |
Preconditions and environment
Tested on both above versions.
Steps to reproduce
export_catalog_product_20240222_205229.test.csv
Expected result
Links purchased seperately checkbox should be unticked.
Actual result
Links purchased seperately checkbox is ticked, even though in the import it is 0 (false).
Additional information
In /module-downloadable-import-export/Model/Import/Product/Type/Downloadable.php, this function:
is looking for "purchased_separately" in the "downloadable_links" column which needless to say doesn't contain this field. However, if we add it, like so:
link_id=1,id=1,purchased_separately=0,title=asdasdasd,sort_order=1,price=0.000000,is_shareable=1,link_type=file,link_file=/s/y/sycamore_row-john_grisham.epub
The import will succeed with links_purchased_separately as unticked. This does not make sense, because links_purchased_separately should be a global field, for all download links not per download link item, and besides, the export exports links_purchased_separately in the "additional_attributes" column, not the "downloadable_links" column.
From what I can tell, the "additional_attributes":
links_purchased_separately=0,links_title=Links,samples_title=Samples
is parsed and merged in $rowData, but somehow ignored. Someone mentioned that the constant self::DEFAULT_PURCHASED_SEPARATELY is wrong being set to true, and should be set to false, but I don't believe that is the correct fix.
Release note
No response
Triage and priority
The text was updated successfully, but these errors were encountered: