Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Small Bug] Filter of Admin Panel listing component cannot hit when field value contains \ #39513

Open
2 of 5 tasks
wubinworks opened this issue Dec 29, 2024 · 2 comments
Open
2 of 5 tasks
Assignees
Labels
Issue: ready for confirmation Reported on 2.4.7 Indicates original Magento version for the Issue report.

Comments

@wubinworks
Copy link

Preconditions and environment

  • Magento 2.4.7
  • Filter of Admin Panel listing component cannot hit when field value contains \
  • When filter is text input and LIKE condition

Steps to reproduce

This is only an example for "CMS Page", but it occurs on all listing component

  1. Go to Admin Panel Content > Elements > Pages
  2. Create a page with title Magento Store
  3. Go back to grid and click Filters button to search title with Magento Store

Result 1: Hit

  1. Create a page with title Magento\Store
  2. Go back to grid and click Filters button to search title with Magento\Store

Result 2: Not Hit (Unexpected)

Expected result

Result 1 & 2 both Hit.

Actual result

Result 2 is Not Hit

Additional information

The UI Component filter cannot deal with \.

Reason is in this line(Input.php#L77).

$value = str_replace(['%', '_'], ['\%', '\_'], $value);

should be

$value = str_replace(['\\', '%', '_'], ['\\\\', '\%', '\_'], $value);

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Dec 29, 2024

Hi @wubinworks. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@github-project-automation github-project-automation bot moved this to Ready for Confirmation in Issue Confirmation and Triage Board Dec 29, 2024
@engcom-Bravo engcom-Bravo added the Reported on 2.4.7 Indicates original Magento version for the Issue report. label Jan 2, 2025
@engcom-Bravo engcom-Bravo self-assigned this Jan 2, 2025
Copy link

m2-assistant bot commented Jan 2, 2025

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: ready for confirmation Reported on 2.4.7 Indicates original Magento version for the Issue report.
Projects
Status: Ready for Confirmation
Development

No branches or pull requests

2 participants