Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpreadsheetSortDialogComponentSpreadsheetComparatorNameAndDirectionRemover: removing the only comparator name also loses the column/row #2979

Open
mP1 opened this issue May 15, 2024 · 0 comments

Comments

@mP1
Copy link
Owner

mP1 commented May 15, 2024

    @Test
    public void testCellOnly() {
        this.refreshAndCheck(
                "A", // columnOrRow
                "comparator-1", // namesList
                "/1/spreadsheetName23/cell/A1:B2/bottom-right/sort/edit/", // historyToken
                "SpreadsheetSortDialogComponentSpreadsheetComparatorNameAndDirectionRemover\n" +
                        "  SpreadsheetCard\n" +
                        "    Card\n" +
                        "      Remove comparator(s)\n" +
                        "        \"comparator-1\" [#/1/spreadsheetName23/cell/A1:B2/bottom-right/sort/edit] id=sort-comparator-0-remove-0-Link\n"
        );
    }

Note Remove comparator link is missing column "A"

    @Test
    public void testCellNotEmpty() {
        this.refreshAndCheck(
                "A", // columnOrRow
                "comparator-1,comparator-2,comparator-3", // namesList
                "/1/spreadsheetName23/cell/A1:B2/bottom-right/sort/edit/", // historyToken
                "SpreadsheetSortDialogComponentSpreadsheetComparatorNameAndDirectionRemover\n" +
                        "  SpreadsheetCard\n" +
                        "    Card\n" +
                        "      Remove comparator(s)\n" +
                        "        \"comparator-1\" [#/1/spreadsheetName23/cell/A1:B2/bottom-right/sort/edit/A=comparator-2,comparator-3] id=sort-comparator-0-remove-0-Link\n" +
                        "        \"comparator-2\" [#/1/spreadsheetName23/cell/A1:B2/bottom-right/sort/edit/A=comparator-1,comparator-3] id=sort-comparator-0-remove-1-Link\n" +
                        "        \"comparator-3\" [#/1/spreadsheetName23/cell/A1:B2/bottom-right/sort/edit/A=comparator-1,comparator-2] id=sort-comparator-0-remove-2-Link\n"
        );
    }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant