Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing flags to lune run is not ergonomic #253

Open
Nicell opened this issue Sep 9, 2024 · 2 comments
Open

Passing flags to lune run is not ergonomic #253

Nicell opened this issue Sep 9, 2024 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@Nicell
Copy link
Contributor

Nicell commented Sep 9, 2024

Currently to pass flags to scripts from lune run, you must add a -- before your arguments to make sure they're passed to the underlying script. This is inconvenient. There's only one flag for lune run, --help, which isn't all the helpful if you already know how to pass a script, so it seems unnecessary to swallow all flags.

One possible solution to this is to forward flags on to the script if a script is provided. We could possibly be even more strict and say any flags after the script argument are forwarded on. This would prevent any Lune specific flags being added on in the future for lune run, but it seems unlikely that'd be needed, and this change would be a nice value add.

@filiptibell filiptibell added the enhancement New feature or request label Sep 9, 2024
@filiptibell filiptibell added this to the 0.9.0 milestone Sep 9, 2024
@filiptibell
Copy link
Collaborator

Seems reasonable to me to remove flag parsing altogether for anything passed after run and pass it to process.env - if a user is running lune run they probably already know how it works and don't need --help. Since it's a breaking change it would be a good opportunity to do it for 0.9.0 which is coming up soon

@CompeyDev
Copy link
Contributor

I'd be against removing --help altogether since there is a possibility of us adding flags like --unsafe for FFI.

Not parsing flags after the script path as Lune options sounds reasonable though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants