-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tracking_column is case sensitive #346
Comments
The setting |
@guyboertje : I agree with you and totally understand your point. If we just read the documentation, |
@romain-chanu: What do you think about this?
@guyboertje: I welcome your input as well. |
@karenzone : it is about the same as the current documentation. That does not reflect what we discussed. I would suggest something along that line:
@guyboertje I know |
Enviromment
Problem
Documentation is confusing. From my understanding,
tracking_column
refers to a column name from a database table. For example, we could imagine a database tableUsers
with a column namedUserID
.If I specify the
tracking_column
to beUserID
(and keeping thelowercase_column_names
to the default value which istrue
), then Logstash will log the following error:tracking_column not found in dataset. {:tracking_column=>"UserID"}
As mentioned in the documentation, each row in the resultset becomes a single event. Columns in the resultset are converted into fields in the event.
If my understanding is correct, Logstash convert the columns names into lowercase and it set the event fields names with the same lowercase values. In that situation, the
tracking_column
value should also be in lowercase.Given a database column named
UserID
, then there could be two configuration possibles depending on one's business needs:Option 1:: Event fields names should be the same as the column names (i.e. case sensitivity is respected):
Option 2:: Event field names should be in lowercase:
Proposal/Suggestion
To avoid confusion, I think the documentation should mention that
tracking_column
value is case sensitive. Its value should be the column name in lowercase iflowercase_column_names
is set totrue
. Otherwise, its value will be the same as the column name (case sensitive).The text was updated successfully, but these errors were encountered: