You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is from a comment in membershipResolver.test.ts:
sometimes (50% of the time?) when we eliminate duplicate ADD_MEMBERs,we're eliminating one that would have needed to have come BEFORE something else, in this case the CHANGE_MEMBER_KEYs action that happens after that person is admitted. Here's an example of a bad graph that you can end up with that way:
👩🏾 ROOT
ADD_MEMBER:👨🦲
<== ADD_MEMBER:👳🏽♂️ was removed from here
INVITE:kPFx4gwGpuWplwa
INVITE:tiKXBLLdMbDndJE
ADMIT:👳🏽♂️
CHANGE_MEMBER_KEYS:{"type":"MEMBER","name":"👳🏽♂️",...} <== we can't do this because 👳🏽♂️ hasn't been added yet
ADD_DEVICE:👳🏽♂️:laptop
ADD_MEMBER:👳🏽♂️
INVITE:dQRE52A+7UGr8X9
ADD_MEMBER:👴
INVITE:j6cC8ZyjyhuojZw
ADMIT:👴
CHANGE_MEMBER_KEYS:{"type":"MEMBER","name":"👴",...}
ADD_DEVICE:👴:laptop
Here's how that graph should have been resolved:
👩🏾 ROOT
ADD_MEMBER:👨🦲
ADD_MEMBER:👳🏽♂️ <== in the bad graph,this ADD_MEMBER was discarded as a duplicate
INVITE:fNpSg0uBcW1vYvf
ADD_MEMBER:👴
INVITE:PkD7SISvUt/3YlJ
ADMIT:👳🏽♂️
CHANGE_MEMBER_KEYS:{"type":"MEMBER","name":"👳🏽♂️",...}
ADD_DEVICE:👳🏽♂️:laptop
<== ADD_MEMBER:👳🏽♂️ was removed from here
INVITE:Pu6NaY6HfbITAf6
INVITE:7vVS0NXz+u15Mx2
ADMIT:👴
CHANGE_MEMBER_KEYS:{"type":"MEMBER","name":"👴",...}
ADD_DEVICE:👴:laptop
The text was updated successfully, but these errors were encountered:
This is from a comment in membershipResolver.test.ts:
The text was updated successfully, but these errors were encountered: