-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sandbox syncing with removed members #21
Comments
Just to be clear why need to connect with removed members (or call them "maybe-removed" members):
This scenario is reflected in this test, which needs to continue to pass. auth/demo/cypress/integration/concurrency.ts Lines 45 to 82 in 1e5ea81
However, this makes it possible for a removed member to keep syncing indefinitely with the remaining members — both providing them new links and receiving links that were added after they were removed. So we need to handle syncing with a maybe-removed member differently. The only reason to sync with a maybe-removed member is to see if they have links that would invalidate their removal. If that's not the case, I should neither accept new links from them, nor give them any links they don't have. Plan:
|
We'll still open a connection and sync with someone who appears to have been removed from the team, in case they have information that would invalidate their removal (e.g. whoever removed them was concurrently demoted or removed themselves).
However, when we're syncing we don't want to provide them any information until we're sure they're still on the team. I think right now a removed member can sync up and continue to get updates to the signature chain.
The text was updated successfully, but these errors were encountered: