Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove clangd's HasValue GMock matcher #121308

Closed
HighCommander4 opened this issue Dec 30, 2024 · 1 comment · Fixed by #121309
Closed

Remove clangd's HasValue GMock matcher #121308

HighCommander4 opened this issue Dec 30, 2024 · 1 comment · Fixed by #121309
Assignees
Labels

Comments

@HighCommander4
Copy link
Collaborator

Clangd's support library defines a GMock matcher called HasValue for matching std::optional (or llvm::Optional at the time of its introduction).

GMock has since added an equivalent matcher of its own called Optional, which we can use instead.

@llvmbot
Copy link
Member

llvmbot commented Dec 30, 2024

@llvm/issue-subscribers-clangd

Author: Nathan Ridge (HighCommander4)

Clangd's support library defines a GMock matcher called [`HasValue`](https://searchfox.org/llvm/rev/7144325109353f9153780f93ec5a8fee8fdc0927/clang-tools-extra/clangd/unittests/Matchers.h#194) for matching `std::optional` (or `llvm::Optional` at the time of its introduction).

GMock has since added an equivalent matcher of its own called Optional, which we can use instead.

HighCommander4 added a commit to HighCommander4/llvm-project that referenced this issue Dec 30, 2024
An equivalent matcher under the name Optional has since been added
upstream to GMock.

Fixes llvm#121308
HighCommander4 added a commit that referenced this issue Jan 2, 2025
An equivalent matcher under the name Optional has since been added
upstream to GMock.

Fixes #121308
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants