Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing AST matcher: dependentTemplateSpecializationType #121307

Open
HighCommander4 opened this issue Dec 30, 2024 · 6 comments
Open

Missing AST matcher: dependentTemplateSpecializationType #121307

HighCommander4 opened this issue Dec 30, 2024 · 6 comments
Assignees
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema" good first issue https://github.com/llvm/llvm-project/contribute

Comments

@HighCommander4
Copy link
Collaborator

Ran into one more missing AST matcher: for types of kind DependentTemplateSpecializationType.

@HighCommander4 HighCommander4 added clang:frontend Language frontend issues, e.g. anything involving "Sema" good first issue https://github.com/llvm/llvm-project/contribute labels Dec 30, 2024
@llvmbot
Copy link
Member

llvmbot commented Dec 30, 2024

@llvm/issue-subscribers-clang-frontend

Author: Nathan Ridge (HighCommander4)

Ran into one more missing AST matcher: for types of kind `DependentTemplateSpecializationType`.

@llvmbot
Copy link
Member

llvmbot commented Dec 30, 2024

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

  1. Check that no other contributor has already been assigned to this issue. If you believe that no one is actually working on it despite an assignment, ping the person. After one week without a response, the assignee may be changed.
  2. In the comments of this issue, request for it to be assigned to you, or just create a pull request after following the steps below. Mention this issue in the description of the pull request.
  3. Fix the issue locally.
  4. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
  5. Create a Git commit.
  6. Run git clang-format HEAD~1 to format your changes.
  7. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation. Mention this issue in the description of the pull request.

If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.

@llvmbot
Copy link
Member

llvmbot commented Dec 30, 2024

@llvm/issue-subscribers-good-first-issue

Author: Nathan Ridge (HighCommander4)

Ran into one more missing AST matcher: for types of kind `DependentTemplateSpecializationType`.

@caokefan
Copy link

Hi, I am new to LLVM and I would like to give it a try. Could you assign it to me?

@HighCommander4
Copy link
Collaborator Author

Hi, I am new to LLVM and I would like to give it a try. Could you assign it to me?

Sure! Thanks for your interest.

There was a similar matcher added recently in #121263, you might find that patch useful as a guide.

@caokefan
Copy link

Hi, I am new to LLVM and I would like to give it a try. Could you assign it to me?

Sure! Thanks for your interest.

There was a similar matcher added recently in #121263, you might find that patch useful as a guide.

OK, I got it, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema" good first issue https://github.com/llvm/llvm-project/contribute
Projects
None yet
Development

No branches or pull requests

3 participants