Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential issue in equation (11) of paper #3

Open
pwein-liveeo opened this issue Dec 10, 2024 · 2 comments
Open

Potential issue in equation (11) of paper #3

pwein-liveeo opened this issue Dec 10, 2024 · 2 comments

Comments

@pwein-liveeo
Copy link

Dear authors,

Thank you for the excellent paper and for sharing your code!

I believe there might be a small issue in equation (11) of the paper. From my understanding, the conditions appear to be reversed. The value 255 should be selected when I_rel(k) == 0. The stated condition in v5 is I_rel(k) == 1. Similarly, for the first row, the condition should be I_rel(k) == 1. This ensures that change maps are only created where the VLM is highly confident in the semantic segmentations of both timesteps, and locations with low confidence for at least one timestep are ignored (255).

This seems consistent with the code in the script.

Could you please confirm whether there is an error in the paper or if I have misunderstood?

Thank you!

@likyoo
Copy link
Owner

likyoo commented Dec 10, 2024

You're right! Thank you for pointing this out, we will correct it in a subsequent version. 😄

@pwein-liveeo
Copy link
Author

Thanks for the extremely fast response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants