Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WorkbenchSplicePlugin causes refreshes #42

Open
jc776 opened this issue Nov 12, 2017 · 0 comments
Open

WorkbenchSplicePlugin causes refreshes #42

jc776 opened this issue Nov 12, 2017 · 0 comments

Comments

@jc776
Copy link

jc776 commented Nov 12, 2017

The line override def requires = WorkbenchPlugin causes the 'refresh' plugin to load. It should be override def requires = WorkbenchBasePlugin.

scalaVersion in ThisBuild := "2.12.4"

val client = project.in(file("client"))
  .settings(
    name := "test-client"
  )
  .enablePlugins(ScalaJSPlugin, WorkbenchSplicePlugin)
workbench.js:121:160
Workbench connected
workbench.js:438:172
workbench: Splicing http://localhost:12345\client\target\scala-2.12\test-client-fastopt.js
workbench.js:124:117
workbench: Checking test-client-jsdeps.js.js
workbench.js:124:117
workbench: Checking test-client-jsdeps.js
workbench.js:124:117
workbench: Checking test-client-fastopt.js.js
workbench.js:124:117
workbench: Checking test-client-fastopt.js
workbench.js:124:117
workbench: Reloading Pages...

If I override that, it does load modified files without refreshing, but none of the 'modify methods while preserving state' behaviour works - I don't think any of the munge regexes work on the current fastOptJS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant