MachO::Binary::extend_section fill gap by default #1154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As demonstrated by @lebr0nli in the sample `ELF/issue_dynamic_table.elf`, the PT_DYNAMIC segment can have an "invalid" offset while still running correctly. This commit changes the logic of the dynamic table processing by using the PT_LOAD segment that wraps this table
The previous implementation extended section by strictly requested amount, possibly creating a gap in case we needed to satisfy alignment requirements. However, information about the size of the gap is lost, and not trivial to recover. This patch changes `extend_section` to extend section by more than requested to avoid creating the gap.
|
Merged through: 9a4f609 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation extended section by strictly requested amount, possibly creating a gap in case we needed to satisfy alignment requirements.
However, information about the size of the gap is lost, and not trivial to recover. This patch changes
extend_sectionto extend section by more than requested to avoid creating the gap.