mkapp issue: Extra build leftovers packaged in app (also present in sandbox after install)

[JonoJensen]

Content (bundled files) from previous builds are built into new application install files.

Question to developers: Maybe this is another bug that should be split out from this bug?:
The left-over files are also present within the sandbox after installation of the packet even tough they are not part of the manifest. Thus seems that the sandbox builder disregards the manifest when installing bundled files. Is that correct?

How to reproduce:
Start with a clean build:

jon@wpKernel8:~/legato/workspace/permoCell$ make clean
rm -rf bin
rm -rf build
jon@wpKernel8:~/legato/workspace/permoCell$ make

Now save state:

jon@wpKernel8:~/legato/workspace/permoCell$ cat build/app/permoCell/permoCell.wp85| bzip2 -cd|tar -tf - > content_permoCell.wp85.before
jon@wpKernel8:~/legato/workspace/permoCell$ find . > before

Modify bundle as:

bundles:
{
    file:
    {
        // [r] ../common/ext/lib/libmosquitto_p1.so.1 /lib/libmosquitto.so.1
        // The commented line above is replaced by the line below ("_test" added to installed file name)
        [r] ../common/ext/lib/libmosquitto_p1.so.1 /lib/libmosquitto_test.so.1
    }
}

I now make an incremental build and again dump context:

jon@wpKernel8:~/legato/workspace/permoCell$ make
mkapp -t wp85 -i /home/jon/legato/legato/new_legato/legato/interfaces/modemServices -i /home/jon/legato/legato/new_legato/legato/interfaces/positioning -L -L../common/ext/lib -i ../common/api -o bin -w build -a permoCell_1.10.1-13-gdedcd30-modified-20171027-082122 permoCell.adef
[37/37] Packaging app
jon@wpKernel8:~/legato/workspace/permoCell$ find . > after 
jon@wpKernel8:~/legato/workspace/permoCell$ cat build/app/permoCell/permoCell.wp85| bzip2 -cd|tar -tf - > content_permoCell.wp85.after 

We now compare state before and after. We would expect at least the old file to disappear from the app package and the new file should replace it. However both files will be present (only one disappear):

jon@wpKernel8:~/legato/workspace/permoCell$ diff before after 
188a189
> ./build/app/permoCell/staging/read-only/lib/libmosquitto_test.so.1
jon@wpKernel8:~/legato/workspace/permoCell$ diff content_permoCell.wp85.before content_permoCell.wp85.after 
8a9
> ./read-only/lib/libmosquitto_test.so.1

Double check content:

jon@wpKernel8:~/legato/workspace/permoCell$ grep libmosq content_permoCell.wp85.after
./read-only/lib/libmosquitto.so.1
./read-only/lib/libmosquitto_test.so.1
jon@wpKernel8:~/legato/workspace/permoCell$