Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing claim search entries - reposts + fee amount #75

Open
tzarebczan opened this issue Jun 27, 2022 · 5 comments
Open

missing claim search entries - reposts + fee amount #75

tzarebczan opened this issue Jun 27, 2022 · 5 comments
Labels
consider soon Discuss this issue at the next planning meeting, then remove this label type: bug Existing functionality is wrong or broken

Comments

@tzarebczan
Copy link

i.e.

{"jsonrpc":"2.0","method":"claim_search","params":{"page_size":20,"page":1,"claim_type":["stream","repost"],"no_totals":true,"not_tags":[],"order_by":["release_time"],"has_source":true,"fee_amount":">=0","channel_ids":["0739af4338a3e9c2307c4170107b30c0af1e1a1f"],"release_time":"<1656102420","include_purchase_receipt":true},"id":1656102468406}

is missing: https://odysee.com/@Cahlen:0/CahlenLee_20220623_DefiningHarm:4

@tzarebczan tzarebczan added type: bug Existing functionality is wrong or broken consider soon Discuss this issue at the next planning meeting, then remove this label labels Jun 27, 2022
@tzarebczan
Copy link
Author

This ended up being a bug due to fee amount filter - it works without it. Removed for now, but this should be fixed.

@tzarebczan tzarebczan changed the title missing claim search entries missing claim search entries - reposts + fee amount Jul 25, 2022
@moodyjon moodyjon self-assigned this Aug 11, 2022
@moodyjon
Copy link
Contributor

Could be similar to lbryio/herald.go#40

@kauffj kauffj transferred this issue from lbryio/herald.go Aug 15, 2022
@moodyjon
Copy link
Contributor

I could not reproduce this against the production hubs using production SDK:

swdev1@Jonathans-Mac-mini herald % curl -v -X POST -H 'Content-Type: application/json' -d '{"jsonrpc":"2.0","method":"version","params":{}}' localhost:5279
Note: Unnecessary use of -X or --request, POST is already inferred.
*   Trying 127.0.0.1:5279...
* Connected to localhost (127.0.0.1) port 5279 (#0)
> POST / HTTP/1.1
> Host: localhost:5279
> User-Agent: curl/7.79.1
> Accept: */*
> Content-Type: application/json
> Content-Length: 48
> 
* Mark bundle as not supporting multiuse
< HTTP/1.1 200 OK
< Content-Type: application/json; charset=utf-8
< Content-Length: 288
< Date: Mon, 15 Aug 2022 16:17:42 GMT
< Server: Python/3.7 aiohttp/3.7.4
< 
{
  "jsonrpc": "2.0",
  "result": {
    "build": "release",
    "lbrynet_version": "0.107.2",
    "os_release": "21.5.0",
    "os_system": "Darwin",
    "platform": "Darwin-21.5.0-x86_64-i386-64bit",
    "processor": "i386",
    "python_version": "3.7.13",
    "version": "0.107.2"
  }
}

The stream was found:

curl -v -X POST -H 'Content-Type: application/json' -d '{"jsonrpc":"2.0","method":"claim_search","params":{"page_size":20,"page":1,"claim_type":["stream","repost"],"no_totals":true,"not_tags":[],"order_by":["release_time"],"has_source":true,"fee_amount":">=0","channel_ids":["0739af4338a3e9c2307c4170107b30c0af1e1a1f"],"release_time":"<1656102420","include_purchase_receipt":true},"id":1656102468406}' localhost:5279

      {
        "address": "bKN8Pb8MFvxvJf98S8wTVF1J2DYjMdqCJM",
        "amount": "1.11",
        "canonical_url": "lbry://@Cahlen#0/CahlenLee_20220623_DefiningHarm#4",
        "claim_id": "4bc3518087f23fc0b83e84119bd30f7edb550e39",
        "claim_op": "create",
        "confirmations": 28381,
        "height": 1181280,
        "is_channel_signature_valid": true,
        "meta": {
          "activation_height": 1181280,
          "creation_height": 1181280,
          "creation_timestamp": 1656016895,
          "effective_amount": "1.18941973",
          "expiration_height": 3283680,
          "is_controlling": true,
          "reposted": 1,
          "support_amount": "0.07941973",
          "take_over_height": 1181280
        },
        "name": "CahlenLee_20220623_DefiningHarm",
        "normalized_name": "cahlenlee_20220623_definingharm",
        "nout": 0,
        "permanent_url": "lbry://CahlenLee_20220623_DefiningHarm#4bc3518087f23fc0b83e84119bd30f7edb550e39",
        "short_url": "lbry://CahlenLee_20220623_DefiningHarm#4",
        "signing_channel": {
          "address": "bCmHHBREHNSURY4x2thRARWeQjMyw3nCa7",
          "amount": "50.0",
          "canonical_url": "lbry://@Cahlen#0",
          "claim_id": "0739af4338a3e9c2307c4170107b30c0af1e1a1f",
          "claim_op": "update",
          "confirmations": 92369,
          "has_signing_key": false,
          "height": 1117292,
          "meta": {
            "activation_height": 1117292,
            "claims_in_channel": 718,
            "creation_height": 691084,
            "creation_timestamp": 1577698690,
            "effective_amount": "1284.957",
            "expiration_height": 3219692,
            "is_controlling": true,
            "reposted": 0,
            "support_amount": "1234.957",
            "take_over_height": 691830
          },
          "name": "@Cahlen",
          "normalized_name": "@cahlen",
          "nout": 0,
          "permanent_url": "lbry://@Cahlen#0739af4338a3e9c2307c4170107b30c0af1e1a1f",
          "short_url": "lbry://@Cahlen#0",
          "timestamp": 1645751675,
          "txid": "e47d3303a96dec612a9f5e245662ea0c0d7be8cbd45659dc16e0a797a0dda4cd",
          "type": "claim",
          "value": {
            "cover": {
              "url": "https://thumbnails.lbry.com/banner-UCXgiWdSbAapi_Z_RNUur0iA"
            },
            "description": "Modern Day Wizard\nhttps://cahlen.org",
            "email": "[email protected]",
            "locations": [
              {
                "country": "US"
              }
            ],
            "public_key": "3056301006072a8648ce3d020106052b8104000a03420004a5bbee1dac43cccd68681ce1e57b860f12fb34e9641ca7624029d74c20bbd78c2b108a78b1516587e2abc0ee8a2dd58b23687947f71367b25890b8d6a51f9ebc",
            "public_key_id": "bXBurQuGrvUShPbtZqiYooCt5VsnxpuD6M",
            "tags": [
              "cryptocurrency",
              "freedom",
              "health",
              "survival",
              "truth"

            ],
            "thumbnail": {
              "url": "https://thumbs.odycdn.com/b5f7471f3564243d15df9d0a8de7e340.jpg"
            },
            "title": "Cahlen",
            "website_url": "https://cahlen.org"
          },
          "value_type": "channel"
        },
        "timestamp": 1656016895,
        "txid": "406d14a55fe25fd03397c943a7b7fddbdfb3e3cf794da798ad927a13e1f0a487",
        "type": "claim",
        "value": {
          "description": "Harm is doing something to someone's body or property without their consent.",
          "source": {
            "hash": "ae2abfbc472d996df47adf7d4b5b139bf5649bba1c1a5128fe7c8c8a9d044f4132c59c45bab2426ec4502a7a436afb40",
            "media_type": "video/mp4",
            "name": "CahlenLee_20220623_DefiningHarm.mp4",
            "sd_hash": "89da68b09b7e8bf465f3e9483fc0bd49f563bb539c1d1c1f29b4598a60bae462370d0e7631da3e2a4d25785598cc0e2e",
            "size": "27322173"
          },
          "stream_type": "video",
          "tags": [
            "law",
            "freedom",
            "truth",
            "philosophy",
            "life"
          ],
          "thumbnail": {
            "url": "https://ipfs.cahlen.org/ipfs/QmTcV1ghDQs7WQ5zMmfuCnwjtYNkBDLoWKdz3bEfQaWtLc"
          },
          "title": "Defining Harm",
          "video": {
            "duration": 209,
            "height": 480,
            "width": 854
          }
        },
        "value_type": "stream"
      },

The claim was the 4th of 20 in the first page.

swdev1@Jonathans-Mac-mini herald % egrep "canonical_url" response.json |wc
      40      80    2594
swdev1@Jonathans-Mac-mini herald % egrep "canonical_url" response.json    
        "canonical_url": "lbry://@Cahlen#0/CahlenLee_20220624_OffgridDinner#a",
          "canonical_url": "lbry://@Cahlen#0",
        "canonical_url": "lbry://@Cahlen#0/CahlenLee_20220624_JerusalemArtichokes#9",
          "canonical_url": "lbry://@Cahlen#0",
        "canonical_url": "lbry://@Cahlen#0/CahlenLee_20220624_ThoughtsonVampires#b",
          "canonical_url": "lbry://@Cahlen#0",
        "canonical_url": "lbry://@Cahlen#0/CahlenLee_20220623_DefiningHarm#4",
          "canonical_url": "lbry://@Cahlen#0",
        "canonical_url": "lbry://@Cahlen#0/CahlenLee_20220623_ThoughtsonDemocracy#d",
          "canonical_url": "lbry://@Cahlen#0",
        "canonical_url": "lbry://@Cahlen#0/CahlenLee_20220621_EnergyWeapons#f",
          "canonical_url": "lbry://@Cahlen#0",
        "canonical_url": "lbry://@Cahlen#0/CahlenLee_20220619_CurrantsforDessert#4",
          "canonical_url": "lbry://@Cahlen#0",
        "canonical_url": "lbry://@Cahlen#0/CahlenLee_20220619_JudgePeople#6",
          "canonical_url": "lbry://@Cahlen#0",
        "canonical_url": "lbry://@Cahlen#0/CahlenLee_20220618_MillbankBag#d",
          "canonical_url": "lbry://@Cahlen#0",
        "canonical_url": "lbry://@Cahlen#0/CahlenLee_20220618_FirstBigRain#e",
          "canonical_url": "lbry://@Cahlen#0",
        "canonical_url": "lbry://@Cahlen#0/CahlenLee_20220615_ThoughtsontheSoul#3",
          "canonical_url": "lbry://@Cahlen#0",
        "canonical_url": "lbry://@Cahlen#0/CahlenLee_20220615_SurvivalGearList#c",
          "canonical_url": "lbry://@Cahlen#0",
        "canonical_url": "lbry://@Cahlen#0/CahlenLee_20220614_ClixmoneyInterviewsCahlen#a",
          "canonical_url": "lbry://@Cahlen#0",
        "canonical_url": "lbry://@Cahlen#0/CahlenLee_20220614_ClimateChangeSorcery#6",
          "canonical_url": "lbry://@Cahlen#0",
        "canonical_url": "lbry://@Cahlen#0/CahlenLee_20220613_GardenUpdate-June13th2022#c",
          "canonical_url": "lbry://@Cahlen#0",
        "canonical_url": "lbry://@Cahlen#0/CahlenLee_20220612_TheyFearGuns#2",
          "canonical_url": "lbry://@Cahlen#0",
        "canonical_url": "lbry://@Cahlen#0/CahlenLee_20220612_TheyWantYoutoDie#b",
          "canonical_url": "lbry://@Cahlen#0",
        "canonical_url": "lbry://@Cahlen#0/CahlenLee_20220611_ThoughtsonTrump#f",
          "canonical_url": "lbry://@Cahlen#0",
        "canonical_url": "lbry://@Cahlen#0/CahlenLee_20220610_SnakeVisit#e",
          "canonical_url": "lbry://@Cahlen#0",
        "canonical_url": "lbry://@Cahlen#0/CahlenLee_20220610_HiveDeepDive#0",
          "canonical_url": "lbry://@Cahlen#0",

@moodyjon
Copy link
Contributor

@tzarebczan

Can you confirm this is no longer happening?

@moodyjon
Copy link
Contributor

Never mind... This is a real issue that has still been happening recently. See #59 for examples not linked to this channel.

For some reason, this particular channel/claim is no longer an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consider soon Discuss this issue at the next planning meeting, then remove this label type: bug Existing functionality is wrong or broken
Projects
None yet
Development

No branches or pull requests

2 participants