From 3a844c2b37d10c626a494885ee90897024002b67 Mon Sep 17 00:00:00 2001 From: Scrub <72096833+ScrubN@users.noreply.github.com> Date: Sat, 17 Aug 2024 17:09:49 -0400 Subject: [PATCH] Cleanup (#1182) * Fix video info table being rounded * Adjust wording of CLI deprecated argument warnings * Update editorconfig --- .editorconfig | 2 ++ TwitchDownloaderCLI/Modes/InfoHandler.cs | 1 - TwitchDownloaderCLI/Tools/PreParseArgs.cs | 10 +++++----- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/.editorconfig b/.editorconfig index 9c342b14..f9358c74 100644 --- a/.editorconfig +++ b/.editorconfig @@ -96,6 +96,8 @@ resharper_csharp_wrap_before_binary_opsign = true resharper_formatter_off_tag = @formatter:off resharper_formatter_on_tag = @formatter:on resharper_formatter_tags_enabled = true +resharper_indent_preprocessor_region = no_indent +resharper_place_accessorholder_attribute_on_same_line = false resharper_place_field_attribute_on_same_line = false resharper_place_simple_anonymousmethod_on_single_line = false resharper_trailing_comma_in_multiline_lists = true diff --git a/TwitchDownloaderCLI/Modes/InfoHandler.cs b/TwitchDownloaderCLI/Modes/InfoHandler.cs index 7ddc3c5e..4640f913 100644 --- a/TwitchDownloaderCLI/Modes/InfoHandler.cs +++ b/TwitchDownloaderCLI/Modes/InfoHandler.cs @@ -117,7 +117,6 @@ private static void HandleVodTable(GqlVideoResponse videoInfo, GqlVideoChapterRe var infoTableTitle = new TableTitle("Video Info"); var infoTable = new Table() .Title(infoTableTitle) - .RoundedBorder() .AddColumn(new TableColumn("Key")) .AddColumn(new TableColumn("Value")) .AddRow(new Markup("Streamer"), GetUserNameMarkup(infoVideo.owner.displayName, infoVideo.owner.login, DEFAULT_STRING)) diff --git a/TwitchDownloaderCLI/Tools/PreParseArgs.cs b/TwitchDownloaderCLI/Tools/PreParseArgs.cs index 017380c0..30d5105e 100644 --- a/TwitchDownloaderCLI/Tools/PreParseArgs.cs +++ b/TwitchDownloaderCLI/Tools/PreParseArgs.cs @@ -41,23 +41,23 @@ private static string[] ConvertFromOldSyntax(string[] args, string processFileNa switch (processedArgs[i]) { case "--embed-emotes": - Console.WriteLine("[INFO] The program has switched from --embed-emotes to -E / --embed-images, consider using those instead. Run \'{0} help\' for more information.", processFileName); + Console.WriteLine("[WARNING] --embed-emotes has been deprecated in favor of -E / --embed-images and may be removed. Run '{0} help' for more information.", processFileName); ConvertEmbedEmoteSyntax(processedArgs, i); break; case "-m" or "--mode": - Console.WriteLine("[INFO] The program has switched from --mode to verbs (like \'git \'), consider using verbs instead. Run \'{0} help\' for more information.", processFileName); + Console.WriteLine("[WARNING] --mode has been deprecated in favor of verbs (like 'git ') and may be removed. Run '{0} help' for more information.", processFileName); ConvertModeSyntax(processedArgs, i); break; case "--silent": - Console.WriteLine("[INFO] The program has switched from --silent to log levels, consider using log levels instead. '--log-level None' will be applied to the current session. Run \'{0} help\' for more information.", processFileName); + Console.WriteLine("[WARNING] --silent has been deprecated in favor of log levels. '--log-level None' will be applied to the current session and may be removed. Run '{0} help' for more information.", processFileName); ConvertSilentSyntax(processedArgs, i); break; case "--verbose-ffmpeg": - Console.WriteLine("[INFO] The program has switched from --verbose-ffmpeg to log levels, consider using log levels instead. '--log-level Status,Info,Warning,Error,Ffmpeg' will be applied to the current session. Run \'{0} help\' for more information.", processFileName); + Console.WriteLine("[WARNING] --verbose-ffmpeg has been deprecated in favor of log levels and may be removed. '--log-level Status,Info,Warning,Error,Ffmpeg' will be applied to the current session. Run '{0} help' for more information.", processFileName); ConvertVerboseFfmpegSyntax(processedArgs, i); break; case "--chat-connections": - Console.WriteLine("[INFO] The program has switched from --chat-connections to -t / --threads, consider using those instead. Run \'{0} help\' for more information.", processFileName); + Console.WriteLine("[WARNING] --chat-connections has been deprecated in favor of -t / --threads and may be removed. Run '{0} help' for more information.", processFileName); ConvertChatConnectionsSyntax(processedArgs, i); break; }