From 092db645a325f4cd139ce97fd35c7dff3e32d8e0 Mon Sep 17 00:00:00 2001
From: Scrub <72096833+ScrubN@users.noreply.github.com>
Date: Fri, 5 Jan 2024 16:26:45 -0500
Subject: [PATCH] Add right-click menu to task queue (#927)

* Add ITwitchTask.CanCancel and ITwitchTask.OutputFile

* Remove now redundant try-catch

* Bind task cancel button enabled-ness to CanCancel
Also update task button method names

* PagChatRender.xaml Solid_ExclamationTriangle -> Solid_ExclamationCircle

* Add Cancel, Error, Remove, and Open Folder items to task queue context menu

* Update translations
---
 TwitchDownloaderWPF/PageChatRender.xaml       |  2 +-
 TwitchDownloaderWPF/PageQueue.xaml            | 30 +++++++-
 TwitchDownloaderWPF/PageQueue.xaml.cs         | 76 ++++++++++++++++---
 .../Translations/Strings.Designer.cs          | 18 +++++
 .../Translations/Strings.es.resx              |  7 ++
 .../Translations/Strings.fr.resx              |  6 ++
 .../Translations/Strings.pl.resx              |  6 ++
 TwitchDownloaderWPF/Translations/Strings.resx |  6 ++
 .../Translations/Strings.ru.resx              |  6 ++
 .../Translations/Strings.tr.resx              |  6 ++
 .../Translations/Strings.uk.resx              |  6 ++
 .../Translations/Strings.zh.resx              |  6 ++
 .../TwitchTasks/ChatDownloadTask.cs           | 16 +++-
 .../TwitchTasks/ChatRenderTask.cs             | 16 +++-
 .../TwitchTasks/ChatUpdateTask.cs             | 16 +++-
 .../TwitchTasks/ClipDownloadTask.cs           | 17 ++++-
 .../TwitchTasks/ITwitchTask.cs                |  3 +-
 .../TwitchTasks/VodDownloadTask.cs            | 16 +++-
 18 files changed, 229 insertions(+), 30 deletions(-)

diff --git a/TwitchDownloaderWPF/PageChatRender.xaml b/TwitchDownloaderWPF/PageChatRender.xaml
index c7560c89..fab704bd 100644
--- a/TwitchDownloaderWPF/PageChatRender.xaml
+++ b/TwitchDownloaderWPF/PageChatRender.xaml
@@ -170,7 +170,7 @@
             <TabItem Header="{lex:Loc RenderTabFfmpeg}" Background="{DynamicResource AppBackground}" Foreground="{DynamicResource AppText}">
                 <StackPanel Orientation="Vertical" Background="{DynamicResource AppBackground}" Margin="5,10,5,5">
                     <WrapPanel Orientation="Horizontal">
-                        <fa:SvgAwesome Icon="Solid_ExclamationTriangle" Width="16" Margin="0,0,3,0" Foreground="{DynamicResource AppText}" />
+                        <fa:SvgAwesome Icon="Solid_ExclamationCircle" Width="16" Margin="0,0,3,0" Foreground="{DynamicResource AppText}" />
                         <TextBlock Text="{lex:Loc RenderFfmpegWarning}" Foreground="{DynamicResource AppInnerText}" FontWeight="Bold" TextWrapping="Wrap" />
                     </WrapPanel>
                     <TextBlock Text="{lex:Loc FfmpegInputArguments}" Margin="0,4,0,0" Foreground="{DynamicResource AppText}"></TextBlock>
diff --git a/TwitchDownloaderWPF/PageQueue.xaml b/TwitchDownloaderWPF/PageQueue.xaml
index cfe0dca9..b337fdbb 100644
--- a/TwitchDownloaderWPF/PageQueue.xaml
+++ b/TwitchDownloaderWPF/PageQueue.xaml
@@ -37,6 +37,30 @@
                     <ItemsControl.ItemTemplate>
                         <DataTemplate>
                             <Border BorderThickness="1" CornerRadius="8" Margin="8,8,8,8" Padding="4" Background="{DynamicResource AppElementBackground}" BorderBrush="{DynamicResource AppElementBorder}">
+                                <Border.ContextMenu>
+                                    <ContextMenu>
+                                        <MenuItem Header="{lex:Loc TaskCancel}" Click="MenuItemCancelTask_Click" IsEnabled="{Binding CanCancel}" Foreground="{DynamicResource AppText}">
+                                            <MenuItem.Icon>
+                                                <fa:SvgAwesome Icon="Solid_StopCircle" Foreground="{DynamicResource AppText}" />
+                                            </MenuItem.Icon>
+                                        </MenuItem>
+                                        <MenuItem Header="{lex:Loc TaskErrorButton}" Click="MenuItemTaskError_Click" Visibility="{Binding Exception.Visibility}" Foreground="{DynamicResource AppText}">
+                                            <MenuItem.Icon>
+                                                <fa:SvgAwesome Icon="Solid_ExclamationTriangle" Foreground="{DynamicResource AppText}" />
+                                            </MenuItem.Icon>
+                                        </MenuItem>
+                                        <MenuItem Header="{lex:Loc ContextMenuRemoveTask}" Click="MenuItemRemoveTask_Click" Foreground="{DynamicResource AppText}">
+                                            <MenuItem.Icon>
+                                                <fa:SvgAwesome Icon="Solid_Times" Foreground="{DynamicResource AppText}" />
+                                            </MenuItem.Icon>
+                                        </MenuItem>
+                                        <MenuItem Header="{lex:Loc ContextMenuOpenTaskFolder}" Click="MenuItemOpenTaskFolder_Click" Foreground="{DynamicResource AppText}">
+                                            <MenuItem.Icon>
+                                                <fa:SvgAwesome Icon="Solid_FolderOpen" Foreground="{DynamicResource AppText}" />
+                                            </MenuItem.Icon>
+                                        </MenuItem>
+                                    </ContextMenu>
+                                </Border.ContextMenu>
                                 <Grid Margin="1,1">
                                     <Grid.ColumnDefinitions>
                                         <ColumnDefinition Width="auto" />
@@ -49,12 +73,12 @@
                                         <TextBlock Text="{Binding TaskType, StringFormat=Task Type: {0}}" Foreground="{DynamicResource AppText}"></TextBlock>
                                         <TextBlock Text="{Binding Status, StringFormat=Status: {0}, Mode=OneWay, NotifyOnSourceUpdated=True, UpdateSourceTrigger=PropertyChanged}" Foreground="{DynamicResource AppText}"></TextBlock>
                                         <StackPanel Orientation="Horizontal" Margin="1,1,0,1">
-                                            <Button Content="{lex:Loc TaskCancel}" Margin="0,0,4,0" MinWidth="60" Height="28" FontSize="12" Click="btnCancelTask_Click" Background="{DynamicResource ActionButtonBackground}" Foreground="{DynamicResource ActionButtonText}" BorderBrush="{DynamicResource ActionButtonBorder}" />
-                                            <Button Visibility="{Binding Exception.Visibility}" Content="{lex:Loc TaskErrorButton}" Margin="0,0,4,0" MinWidth="60" Height="28" FontSize="12" Click="btnTaskError_Click" Background="{DynamicResource ActionButtonBackground}" Foreground="{DynamicResource ActionButtonText}" BorderBrush="{DynamicResource ActionButtonBorder}" />
+                                            <Button Content="{lex:Loc TaskCancel}" Margin="0,0,4,0" MinWidth="60" Height="28" FontSize="12" Click="BtnCancelTask_Click" IsEnabled="{Binding CanCancel}" Background="{DynamicResource ActionButtonBackground}" Foreground="{DynamicResource ActionButtonText}" BorderBrush="{DynamicResource ActionButtonBorder}" />
+                                            <Button Visibility="{Binding Exception.Visibility}" Content="{lex:Loc TaskErrorButton}" Margin="0,0,4,0" MinWidth="60" Height="28" FontSize="12" Click="BtnTaskError_Click" Background="{DynamicResource ActionButtonBackground}" Foreground="{DynamicResource ActionButtonText}" BorderBrush="{DynamicResource ActionButtonBorder}" />
                                             <ProgressBar Height="16" Width="200" Minimum="0" Maximum="100" Value="{Binding Progress, Mode=OneWay, NotifyOnSourceUpdated=True, UpdateSourceTrigger=PropertyChanged}" HorizontalAlignment="Left" Background="{DynamicResource AppElementInnerBackground}" Foreground="{DynamicResource ProgressBarForeground}" />
                                         </StackPanel>
                                     </StackPanel>
-                                    <Button Grid.Column="2" Padding="7, 0" VerticalAlignment="Top" Height="24" FontSize="12" Content="X" Click="btnRemoveTask_Click" Background="{DynamicResource AppElementBackground}" Foreground="{DynamicResource AppTextDisabled}" BorderBrush="{DynamicResource AppElementBorder}" />
+                                    <Button Grid.Column="2" Padding="7, 0" VerticalAlignment="Top" Height="24" FontSize="12" Content="X" Click="BtnRemoveTask_Click" Background="{DynamicResource AppElementBackground}" Foreground="{DynamicResource AppTextDisabled}" BorderBrush="{DynamicResource AppElementBorder}" />
                                 </Grid>
                             </Border>
                         </DataTemplate>
diff --git a/TwitchDownloaderWPF/PageQueue.xaml.cs b/TwitchDownloaderWPF/PageQueue.xaml.cs
index b0e2d42a..473bffe1 100644
--- a/TwitchDownloaderWPF/PageQueue.xaml.cs
+++ b/TwitchDownloaderWPF/PageQueue.xaml.cs
@@ -6,6 +6,7 @@
 using TwitchDownloaderWPF.TwitchTasks;
 using TwitchDownloaderWPF.Properties;
 using System.Diagnostics;
+using System.IO;
 
 namespace TwitchDownloaderWPF
 {
@@ -199,38 +200,64 @@ private void btnClips_Click(object sender, RoutedEventArgs e)
             window.ShowDialog();
         }
 
-        private void btnCancelTask_Click(object sender, RoutedEventArgs e)
+        private void BtnCancelTask_Click(object sender, RoutedEventArgs e)
         {
-            if (!(sender is Button { DataContext: ITwitchTask task } cancelButton))
+            if (sender is not Button { DataContext: ITwitchTask task })
             {
                 return;
             }
 
-            cancelButton.IsEnabled = false;
+            CancelTask(task);
+        }
 
-            if (task.Status is TwitchTaskStatus.Failed or TwitchTaskStatus.Canceled or TwitchTaskStatus.Finished)
+        private void MenuItemCancelTask_Click(object sender, RoutedEventArgs e)
+        {
+            if (sender is not MenuItem { DataContext: ITwitchTask task })
             {
                 return;
             }
 
-            task.Cancel();
+            CancelTask(task);
+        }
+
+        private static void CancelTask(ITwitchTask task)
+        {
+            if (task.CanCancel)
+            {
+                task.Cancel();
+            }
         }
 
-        private void btnTaskError_Click(object sender, RoutedEventArgs e)
+        private void BtnTaskError_Click(object sender, RoutedEventArgs e)
         {
             if (sender is not Button { DataContext: ITwitchTask task })
             {
                 return;
             }
 
-            TwitchTaskException taskException = task.Exception;
+            ShowTaskException(task);
+        }
+
+        private void MenuItemTaskError_Click(object sender, RoutedEventArgs e)
+        {
+            if (sender is not MenuItem { DataContext: ITwitchTask task })
+            {
+                return;
+            }
+
+            ShowTaskException(task);
+        }
+
+        private static void ShowTaskException(ITwitchTask task)
+        {
+            var taskException = task.Exception;
 
             if (taskException?.Exception == null)
             {
                 return;
             }
 
-            string errorMessage = taskException.Exception.Message;
+            var errorMessage = taskException.Exception.Message;
             if (Settings.Default.VerboseErrors)
             {
                 errorMessage = taskException.Exception.ToString();
@@ -239,13 +266,28 @@ private void btnTaskError_Click(object sender, RoutedEventArgs e)
             MessageBox.Show(errorMessage, Translations.Strings.MessageBoxTitleError, MessageBoxButton.OK, MessageBoxImage.Error);
         }
 
-        private void btnRemoveTask_Click(object sender, RoutedEventArgs e)
+        private void BtnRemoveTask_Click(object sender, RoutedEventArgs e)
         {
             if (sender is not Button { DataContext: ITwitchTask task })
             {
                 return;
             }
 
+            RemoveTask(task);
+        }
+
+        private void MenuItemRemoveTask_Click(object sender, RoutedEventArgs e)
+        {
+            if (sender is not MenuItem { DataContext: ITwitchTask task })
+            {
+                return;
+            }
+
+            RemoveTask(task);
+        }
+
+        private static void RemoveTask(ITwitchTask task)
+        {
             if (task.CanRun() || task.Status is TwitchTaskStatus.Running or TwitchTaskStatus.Waiting)
             {
                 MessageBox.Show(Translations.Strings.CancelTaskBeforeRemoving, Translations.Strings.TaskCouldNotBeRemoved, MessageBoxButton.OK, MessageBoxImage.Information);
@@ -257,5 +299,21 @@ private void btnRemoveTask_Click(object sender, RoutedEventArgs e)
                 MessageBox.Show(Translations.Strings.TaskCouldNotBeRemoved, Translations.Strings.UnknownErrorOccurred, MessageBoxButton.OK, MessageBoxImage.Error);
             }
         }
+
+        private void MenuItemOpenTaskFolder_Click(object sender, RoutedEventArgs e)
+        {
+            if (sender is not MenuItem { DataContext: ITwitchTask task })
+            {
+                return;
+            }
+
+            var outputFolder = Path.GetDirectoryName(task.OutputFile);
+            if (!Directory.Exists(outputFolder))
+            {
+                return;
+            }
+
+            Process.Start(new ProcessStartInfo(outputFolder) { UseShellExecute = true });
+        }
     }
 }
diff --git a/TwitchDownloaderWPF/Translations/Strings.Designer.cs b/TwitchDownloaderWPF/Translations/Strings.Designer.cs
index 5ddc495e..d53b74d5 100644
--- a/TwitchDownloaderWPF/Translations/Strings.Designer.cs
+++ b/TwitchDownloaderWPF/Translations/Strings.Designer.cs
@@ -446,6 +446,24 @@ public static string ClipLinkId {
             }
         }
         
+        /// <summary>
+        ///   Looks up a localized string similar to Open folder.
+        /// </summary>
+        public static string ContextMenuOpenTaskFolder {
+            get {
+                return ResourceManager.GetString("ContextMenuOpenTaskFolder", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to Remove.
+        /// </summary>
+        public static string ContextMenuRemoveTask {
+            get {
+                return ResourceManager.GetString("ContextMenuRemoveTask", resourceCulture);
+            }
+        }
+        
         /// <summary>
         ///   Looks up a localized string similar to Copy ID to clipboard.
         /// </summary>
diff --git a/TwitchDownloaderWPF/Translations/Strings.es.resx b/TwitchDownloaderWPF/Translations/Strings.es.resx
index 305244ff..8939bebf 100644
--- a/TwitchDownloaderWPF/Translations/Strings.es.resx
+++ b/TwitchDownloaderWPF/Translations/Strings.es.resx
@@ -808,4 +808,11 @@
   <data name="ButtonCancelSettingsChanges" xml:space="preserve">
     <value>Cancel</value>
   </data>
+  <data name="ContextMenuRemoveTask" xml:space="preserve">
+    <value>Remove</value>
+  </data>
+  <data name="ContextMenuOpenTaskFolder" xml:space="preserve">
+    <value>Open folder
+</value>
+  </data>
 </root>
\ No newline at end of file
diff --git a/TwitchDownloaderWPF/Translations/Strings.fr.resx b/TwitchDownloaderWPF/Translations/Strings.fr.resx
index 22826654..677ac78a 100644
--- a/TwitchDownloaderWPF/Translations/Strings.fr.resx
+++ b/TwitchDownloaderWPF/Translations/Strings.fr.resx
@@ -807,4 +807,10 @@
   <data name="ButtonCancelSettingsChanges" xml:space="preserve">
     <value>Cancel</value>
   </data>
+  <data name="ContextMenuRemoveTask" xml:space="preserve">
+    <value>Remove</value>
+  </data>
+  <data name="ContextMenuOpenTaskFolder" xml:space="preserve">
+    <value>Open folder</value>
+  </data>
 </root>
\ No newline at end of file
diff --git a/TwitchDownloaderWPF/Translations/Strings.pl.resx b/TwitchDownloaderWPF/Translations/Strings.pl.resx
index b12b7e5f..e68d6d0f 100644
--- a/TwitchDownloaderWPF/Translations/Strings.pl.resx
+++ b/TwitchDownloaderWPF/Translations/Strings.pl.resx
@@ -807,4 +807,10 @@
   <data name="ButtonCancelSettingsChanges" xml:space="preserve">
     <value>Cancel</value>
   </data>
+  <data name="ContextMenuRemoveTask" xml:space="preserve">
+    <value>Remove</value>
+  </data>
+  <data name="ContextMenuOpenTaskFolder" xml:space="preserve">
+    <value>Open folder</value>
+  </data>
 </root>
\ No newline at end of file
diff --git a/TwitchDownloaderWPF/Translations/Strings.resx b/TwitchDownloaderWPF/Translations/Strings.resx
index 6907cad0..7690f45b 100644
--- a/TwitchDownloaderWPF/Translations/Strings.resx
+++ b/TwitchDownloaderWPF/Translations/Strings.resx
@@ -806,4 +806,10 @@
   <data name="ButtonCancelSettingsChanges" xml:space="preserve">
     <value>Cancel</value>
   </data>
+  <data name="ContextMenuRemoveTask" xml:space="preserve">
+    <value>Remove</value>
+  </data>
+  <data name="ContextMenuOpenTaskFolder" xml:space="preserve">
+    <value>Open folder</value>
+  </data>
 </root>
\ No newline at end of file
diff --git a/TwitchDownloaderWPF/Translations/Strings.ru.resx b/TwitchDownloaderWPF/Translations/Strings.ru.resx
index 32f41efd..450dd843 100644
--- a/TwitchDownloaderWPF/Translations/Strings.ru.resx
+++ b/TwitchDownloaderWPF/Translations/Strings.ru.resx
@@ -807,4 +807,10 @@
   <data name="ButtonCancelSettingsChanges" xml:space="preserve">
     <value>Cancel</value>
   </data>
+  <data name="ContextMenuRemoveTask" xml:space="preserve">
+    <value>Remove</value>
+  </data>
+  <data name="ContextMenuOpenTaskFolder" xml:space="preserve">
+    <value>Open folder</value>
+  </data>
 </root>
\ No newline at end of file
diff --git a/TwitchDownloaderWPF/Translations/Strings.tr.resx b/TwitchDownloaderWPF/Translations/Strings.tr.resx
index 39670fb5..fc777e3a 100644
--- a/TwitchDownloaderWPF/Translations/Strings.tr.resx
+++ b/TwitchDownloaderWPF/Translations/Strings.tr.resx
@@ -808,4 +808,10 @@
   <data name="ButtonCancelSettingsChanges" xml:space="preserve">
     <value>Cancel</value>
   </data>
+  <data name="ContextMenuRemoveTask" xml:space="preserve">
+    <value>Remove</value>
+  </data>
+  <data name="ContextMenuOpenTaskFolder" xml:space="preserve">
+    <value>Open folder</value>
+  </data>
 </root>
\ No newline at end of file
diff --git a/TwitchDownloaderWPF/Translations/Strings.uk.resx b/TwitchDownloaderWPF/Translations/Strings.uk.resx
index 56067b59..4bb5afa0 100644
--- a/TwitchDownloaderWPF/Translations/Strings.uk.resx
+++ b/TwitchDownloaderWPF/Translations/Strings.uk.resx
@@ -807,4 +807,10 @@
   <data name="ButtonCancelSettingsChanges" xml:space="preserve">
     <value>Скасувати</value>
   </data>
+  <data name="ContextMenuRemoveTask" xml:space="preserve">
+    <value>Remove</value>
+  </data>
+  <data name="ContextMenuOpenTaskFolder" xml:space="preserve">
+    <value>Open folder</value>
+  </data>
 </root>
diff --git a/TwitchDownloaderWPF/Translations/Strings.zh.resx b/TwitchDownloaderWPF/Translations/Strings.zh.resx
index d384243d..af360a74 100644
--- a/TwitchDownloaderWPF/Translations/Strings.zh.resx
+++ b/TwitchDownloaderWPF/Translations/Strings.zh.resx
@@ -806,4 +806,10 @@
   <data name="ButtonCancelSettingsChanges" xml:space="preserve">
     <value>Cancel</value>
   </data>
+  <data name="ContextMenuRemoveTask" xml:space="preserve">
+    <value>Remove</value>
+  </data>
+  <data name="ContextMenuOpenTaskFolder" xml:space="preserve">
+    <value>Open folder</value>
+  </data>
 </root>
\ No newline at end of file
diff --git a/TwitchDownloaderWPF/TwitchTasks/ChatDownloadTask.cs b/TwitchDownloaderWPF/TwitchTasks/ChatDownloadTask.cs
index d228c48b..52c610e6 100644
--- a/TwitchDownloaderWPF/TwitchTasks/ChatDownloadTask.cs
+++ b/TwitchDownloaderWPF/TwitchTasks/ChatDownloadTask.cs
@@ -17,16 +17,19 @@ class ChatDownloadTask : ITwitchTask
         public ITwitchTask DependantTask { get; set; }
         public string TaskType { get; } = Translations.Strings.ChatDownload;
         public TwitchTaskException Exception { get; private set; } = new();
+        public string OutputFile => DownloadOptions.Filename;
+        public bool CanCancel { get; private set; } = true;
 
         public event PropertyChangedEventHandler PropertyChanged;
 
         public void Cancel()
         {
-            try
+            if (!CanCancel)
             {
-                TokenSource.Cancel();
+                return;
             }
-            catch (ObjectDisposedException) { }
+
+            TokenSource.Cancel();
 
             if (Status == TwitchTaskStatus.Running)
             {
@@ -46,6 +49,12 @@ public void ChangeStatus(TwitchTaskStatus newStatus)
         {
             Status = newStatus;
             OnPropertyChanged(nameof(Status));
+
+            if (CanCancel && newStatus is TwitchTaskStatus.Canceled or TwitchTaskStatus.Failed or TwitchTaskStatus.Finished or TwitchTaskStatus.Stopping)
+            {
+                CanCancel = false;
+                OnPropertyChanged(nameof(CanCancel));
+            }
         }
 
         public async Task RunAsync()
@@ -53,6 +62,7 @@ public async Task RunAsync()
             if (TokenSource.IsCancellationRequested)
             {
                 TokenSource.Dispose();
+                ChangeStatus(TwitchTaskStatus.Canceled);
                 return;
             }
 
diff --git a/TwitchDownloaderWPF/TwitchTasks/ChatRenderTask.cs b/TwitchDownloaderWPF/TwitchTasks/ChatRenderTask.cs
index 42b375b2..4af99dfd 100644
--- a/TwitchDownloaderWPF/TwitchTasks/ChatRenderTask.cs
+++ b/TwitchDownloaderWPF/TwitchTasks/ChatRenderTask.cs
@@ -17,16 +17,19 @@ class ChatRenderTask : ITwitchTask
         public ITwitchTask DependantTask { get; set; }
         public string TaskType { get; } = Translations.Strings.ChatRender;
         public TwitchTaskException Exception { get; private set; } = new();
+        public string OutputFile => DownloadOptions.OutputFile;
+        public bool CanCancel { get; private set; } = true;
 
         public event PropertyChangedEventHandler PropertyChanged;
 
         public void Cancel()
         {
-            try
+            if (!CanCancel)
             {
-                TokenSource.Cancel();
+                return;
             }
-            catch (ObjectDisposedException) { }
+
+            TokenSource.Cancel();
 
             if (Status == TwitchTaskStatus.Running)
             {
@@ -65,6 +68,12 @@ public void ChangeStatus(TwitchTaskStatus newStatus)
         {
             Status = newStatus;
             OnPropertyChanged(nameof(Status));
+
+            if (CanCancel && newStatus is TwitchTaskStatus.Canceled or TwitchTaskStatus.Failed or TwitchTaskStatus.Finished or TwitchTaskStatus.Stopping)
+            {
+                CanCancel = false;
+                OnPropertyChanged(nameof(CanCancel));
+            }
         }
 
         public async Task RunAsync()
@@ -72,6 +81,7 @@ public async Task RunAsync()
             if (TokenSource.IsCancellationRequested)
             {
                 TokenSource.Dispose();
+                ChangeStatus(TwitchTaskStatus.Canceled);
                 return;
             }
 
diff --git a/TwitchDownloaderWPF/TwitchTasks/ChatUpdateTask.cs b/TwitchDownloaderWPF/TwitchTasks/ChatUpdateTask.cs
index 13bdd531..2b10c7fb 100644
--- a/TwitchDownloaderWPF/TwitchTasks/ChatUpdateTask.cs
+++ b/TwitchDownloaderWPF/TwitchTasks/ChatUpdateTask.cs
@@ -17,16 +17,19 @@ class ChatUpdateTask : ITwitchTask
         public ITwitchTask DependantTask { get; set; }
         public string TaskType { get; } = Translations.Strings.ChatUpdate;
         public TwitchTaskException Exception { get; private set; } = new();
+        public string OutputFile => UpdateOptions.OutputFile;
+        public bool CanCancel { get; private set; } = true;
 
         public event PropertyChangedEventHandler PropertyChanged;
 
         public void Cancel()
         {
-            try
+            if (!CanCancel)
             {
-                TokenSource.Cancel();
+                return;
             }
-            catch (ObjectDisposedException) { }
+
+            TokenSource.Cancel();
 
             if (Status == TwitchTaskStatus.Running)
             {
@@ -46,6 +49,12 @@ public void ChangeStatus(TwitchTaskStatus newStatus)
         {
             Status = newStatus;
             OnPropertyChanged(nameof(Status));
+
+            if (CanCancel && newStatus is TwitchTaskStatus.Canceled or TwitchTaskStatus.Failed or TwitchTaskStatus.Finished or TwitchTaskStatus.Stopping)
+            {
+                CanCancel = false;
+                OnPropertyChanged(nameof(CanCancel));
+            }
         }
 
         public async Task RunAsync()
@@ -53,6 +62,7 @@ public async Task RunAsync()
             if (TokenSource.IsCancellationRequested)
             {
                 TokenSource.Dispose();
+                ChangeStatus(TwitchTaskStatus.Canceled);
                 return;
             }
 
diff --git a/TwitchDownloaderWPF/TwitchTasks/ClipDownloadTask.cs b/TwitchDownloaderWPF/TwitchTasks/ClipDownloadTask.cs
index a768cb62..274f4565 100644
--- a/TwitchDownloaderWPF/TwitchTasks/ClipDownloadTask.cs
+++ b/TwitchDownloaderWPF/TwitchTasks/ClipDownloadTask.cs
@@ -17,16 +17,19 @@ class ClipDownloadTask : ITwitchTask
         public ITwitchTask DependantTask { get; set; }
         public string TaskType { get; } = Translations.Strings.ClipDownload;
         public TwitchTaskException Exception { get; private set; } = new();
+        public string OutputFile => DownloadOptions.Filename;
+        public bool CanCancel { get; private set; } = true;
 
         public event PropertyChangedEventHandler PropertyChanged;
 
         public void Cancel()
         {
-            try
+            if (!CanCancel)
             {
-                TokenSource.Cancel();
+                return;
             }
-            catch (ObjectDisposedException) { }
+
+            TokenSource.Cancel();
 
             if (Status == TwitchTaskStatus.Running)
             {
@@ -46,6 +49,12 @@ public void ChangeStatus(TwitchTaskStatus newStatus)
         {
             Status = newStatus;
             OnPropertyChanged(nameof(Status));
+
+            if (CanCancel && newStatus is TwitchTaskStatus.Canceled or TwitchTaskStatus.Failed or TwitchTaskStatus.Finished or TwitchTaskStatus.Stopping)
+            {
+                CanCancel = false;
+                OnPropertyChanged(nameof(CanCancel));
+            }
         }
 
         public async Task RunAsync()
@@ -53,10 +62,10 @@ public async Task RunAsync()
             if (TokenSource.IsCancellationRequested)
             {
                 TokenSource.Dispose();
+                ChangeStatus(TwitchTaskStatus.Canceled);
                 return;
             }
 
-
             Progress<ProgressReport> progress = new Progress<ProgressReport>();
             progress.ProgressChanged += Progress_ProgressChanged;
             ClipDownloader downloader = new ClipDownloader(DownloadOptions, progress);
diff --git a/TwitchDownloaderWPF/TwitchTasks/ITwitchTask.cs b/TwitchDownloaderWPF/TwitchTasks/ITwitchTask.cs
index 5653627c..6445ca35 100644
--- a/TwitchDownloaderWPF/TwitchTasks/ITwitchTask.cs
+++ b/TwitchDownloaderWPF/TwitchTasks/ITwitchTask.cs
@@ -24,10 +24,11 @@ public interface ITwitchTask : INotifyPropertyChanged
         ITwitchTask DependantTask { get; set; }
         string TaskType { get; }
         TwitchTaskException Exception { get; }
+        string OutputFile { get; }
+        bool CanCancel { get; }
 
         Task RunAsync();
         void Cancel();
         bool CanRun();
-        void ChangeStatus(TwitchTaskStatus newStatus);
     }
 }
diff --git a/TwitchDownloaderWPF/TwitchTasks/VodDownloadTask.cs b/TwitchDownloaderWPF/TwitchTasks/VodDownloadTask.cs
index 73d1cac7..95f64074 100644
--- a/TwitchDownloaderWPF/TwitchTasks/VodDownloadTask.cs
+++ b/TwitchDownloaderWPF/TwitchTasks/VodDownloadTask.cs
@@ -17,16 +17,19 @@ class VodDownloadTask : ITwitchTask
         public ITwitchTask DependantTask { get; set; }
         public string TaskType { get; } = Translations.Strings.VodDownload;
         public TwitchTaskException Exception { get; private set; } = new();
+        public string OutputFile => DownloadOptions.Filename;
+        public bool CanCancel { get; private set; } = true;
 
         public event PropertyChangedEventHandler PropertyChanged;
 
         public void Cancel()
         {
-            try
+            if (!CanCancel)
             {
-                TokenSource.Cancel();
+                return;
             }
-            catch (ObjectDisposedException) { }
+
+            TokenSource.Cancel();
 
             if (Status == TwitchTaskStatus.Running)
             {
@@ -46,6 +49,12 @@ public void ChangeStatus(TwitchTaskStatus newStatus)
         {
             Status = newStatus;
             OnPropertyChanged(nameof(Status));
+
+            if (CanCancel && newStatus is TwitchTaskStatus.Canceled or TwitchTaskStatus.Failed or TwitchTaskStatus.Finished or TwitchTaskStatus.Stopping)
+            {
+                CanCancel = false;
+                OnPropertyChanged(nameof(CanCancel));
+            }
         }
 
         public async Task RunAsync()
@@ -53,6 +62,7 @@ public async Task RunAsync()
             if (TokenSource.IsCancellationRequested)
             {
                 TokenSource.Dispose();
+                ChangeStatus(TwitchTaskStatus.Canceled);
                 return;
             }