Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup: use the useCallback hook where appropriate #17

Open
SyntaxBlitz opened this issue May 28, 2020 · 2 comments
Open

Cleanup: use the useCallback hook where appropriate #17

SyntaxBlitz opened this issue May 28, 2020 · 2 comments
Labels
chore Cleanup, dependency upgrades, or other boring stuff.

Comments

@SyntaxBlitz
Copy link
Contributor

I think we need a lot of these, but I never really bothered when I was prototyping.
@SyntaxBlitz SyntaxBlitz added the chore Cleanup, dependency upgrades, or other boring stuff. label May 28, 2020
@schonfeld
Copy link
Contributor

schonfeld commented Jun 16, 2020 •
edited
Loading

Tacking onto this, I've noticed a lot of props.navigation.addListener that can benefit from using react-navigation's own hooks useFocusEffect and useIsFocused

edit: I actually got most of these done in #27

@SyntaxBlitz
Copy link
Contributor Author

totally agree, I found out about that hook pretty late so never actually used it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Cleanup, dependency upgrades, or other boring stuff.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@schonfeld @SyntaxBlitz