Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant isset(s) #12

Closed
weierophinney opened this issue Dec 31, 2019 · 7 comments
Closed

remove redundant isset(s) #12

weierophinney opened this issue Dec 31, 2019 · 7 comments

Comments

@weierophinney
Copy link
Member

when we are also testing with ! empty() I believe we can skip isset() checks, as the execution speed is nearly the same (but it will double for positive isset)


Originally posted by @pine3ree at zendframework/zend-servicemanager#262

@weierophinney
Copy link
Member Author

@pine3ree as this is an improvement, please target develop


Originally posted by @Ocramius at zendframework/zend-servicemanager#262 (comment)

@weierophinney
Copy link
Member Author

@pine3ree please attempt a rebase - don't merge upstream into your dev branches :)


Originally posted by @Ocramius at zendframework/zend-servicemanager#262 (comment)

@weierophinney
Copy link
Member Author

@pine3ree ah, that's alright. If you are not familiar with the rebase process, I'll just do it on merge :-)


Originally posted by @Ocramius at zendframework/zend-servicemanager#262 (comment)

@weierophinney
Copy link
Member Author

ok, thank You @Ocramius ! kind regards!


Originally posted by @pine3ree at zendframework/zend-servicemanager#262 (comment)

@weierophinney
Copy link
Member Author

@pine3ree just in case you've other conflicted branch in other/next Pull Request, I made blog post about rebase conflicted branch https://samsonasik.wordpress.com/2015/09/16/practical-git-4-rebasing-conflicted-task-branch-against-primary-branch/


Originally posted by @samsonasik at zendframework/zend-servicemanager#262 (comment)

@weierophinney
Copy link
Member Author

@samsonasik
Thank You! that's very kind of You, sir! Regards!


Originally posted by @pine3ree at zendframework/zend-servicemanager#262 (comment)

@GeeH
Copy link
Contributor

GeeH commented Jun 5, 2020

I'm going to close as this just doesn't wash it's face for a move to the new repo at the moment -- massive thank you to @pine3ree for the original contribution and please feel free to re-create this PR on this new repo if you wish.

@GeeH GeeH closed this as completed Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants