-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHPStan fixes #9
Comments
@Ocramius I can add phpstan on CI, but just a low level. Too many errors depends on other libraries. Originally posted by @thomasvargiu at zendframework/zend-mvc#296 (comment) |
@thomasvargiu that's fine - we can raise the level as we get better Originally posted by @Ocramius at zendframework/zend-mvc#296 (comment) |
@thomasvargiu btw, I still suggest getting rid of all the Originally posted by @Ocramius at zendframework/zend-mvc#296 (comment) |
@Ocramius I'm still working on this. I set this PR as WIP Originally posted by @thomasvargiu at zendframework/zend-mvc#296 (comment) |
Done. Needs a complete review Originally posted by @thomasvargiu at zendframework/zend-mvc#296 (comment) |
Based on this https://github.com/laminas/technical-steering-committee/blob/429d1c7cd38bebd45aff08bfd61618726d9c6b03/meetings/minutes/2020-08-03-TSC-Minutes.md#vote-on-static-analysis-tooling , we are going to use psalm. I am closing this. |
In order to bump to PHP 7 minimum version in the future, I used phpstan to static analyse the code, correcting some phpdoc errors and adding guards throwing exceptions when needed. Code quality will be improved when other components will be improved.
It's just a first step, but I think it will be useful.
I don't know if this could be considered a BC break, probably it isn't.
Originally posted by @thomasvargiu at zendframework/zend-mvc#296
The text was updated successfully, but these errors were encountered: