Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Secret Management and Test Configuration Handling #343

Open
Teneroy opened this issue Jan 20, 2025 · 1 comment · May be fixed by #348
Open

Improve Secret Management and Test Configuration Handling #343

Teneroy opened this issue Jan 20, 2025 · 1 comment · May be fixed by #348
Assignees

Comments

@Teneroy
Copy link
Collaborator

Teneroy commented Jan 20, 2025

Secret Management
Currently, it is really hard to update GH Action secrets as GH doesn't display the values. Hence, we need to have the same names in GH and our storage. We should never forget to update our storage if GH secret is updated.
The current existing unused secrets should be deleted too.

Improve test configuration
Currently, test configuration can be done in the .env.test which is old approach. Normally all configuration is done in config.json file.
We should set different config path in .env file, e.g. CONFIG_PATH=config/config.test.json, if we want to configure for tests in a separate file.

@mfaizanse mfaizanse self-assigned this Jan 22, 2025
@mfaizanse mfaizanse linked a pull request Jan 22, 2025 that will close this issue
@mfaizanse mfaizanse linked a pull request Jan 22, 2025 that will close this issue
@mfaizanse
Copy link
Member

mfaizanse commented Jan 23, 2025

  • Update integration tests in pre-main.
  • Update integration in release pipeline
  • Validation tests
  • Evaluation tests
  • Update evaluation and validation tests docs
  • Update github secrets doc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants