Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some form of audio support #37

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

powpingdone
Copy link
Contributor

@powpingdone powpingdone commented Nov 7, 2024

Closes #31

@powpingdone
Copy link
Contributor Author

powpingdone commented Nov 7, 2024

Sidenote: the way that I implemented this makes it so that it doesn't require package rebuilds.

@powpingdone
Copy link
Contributor Author

This is currently a draft due to speakersafetyd/unknown if speakers have hardware limiting.

@kuruczgy
Copy link
Owner

kuruczgy commented Nov 8, 2024

Cool, will test when I have time, thanks.

How well is it working for you? Jos reported that "it will sound very distorted".

Yeah, we should probably wait for a while before merging this, see if any work comes along on the speakersafetyd front.

But if not, and otherwise it's working without issues for us, we could consider merging it behind an op-in enable flag along with a stern warning in the README about people being responsible for breaking their own speakers.

@powpingdone
Copy link
Contributor Author

It is definitely distorted, even to my not-audiophile ears.

@powpingdone
Copy link
Contributor Author

I guess we could put it behind a config flag.

@powpingdone
Copy link
Contributor Author

Also, I don't have my good recording equipment on me ATM so I can't replay a sample for you.

@powpingdone
Copy link
Contributor Author

powpingdone commented Nov 12, 2024

Huh? https://psref.lenovo.com/Detail/Yoga_Slim_7_14Q8X9?M=83ED0001US

4 stereo speakers, 2W x2 (woofers), 2W x2 (tweeters), optimized with Dolby Atmos®, Smart Amplifier (AMP)

Does that mean it's already protected by hardware? @kuruczgy

@kuruczgy
Copy link
Owner

I have no idea... you might wanna ask about this in #aarch64-laptops, there are some more knowledgeable people there.

But there is already one person with a Yoga Slim 7x there who seems to have broken their speakers, so until we have strong evidence that there is hardware protection and that person is having some other issue, I will assume there isn't.

modules/audio.nix Outdated Show resolved Hide resolved
@kuruczgy
Copy link
Owner

Also wanted to ask @powpingdone, what nix formatter are you using? I am using nixpkgs-fmt, but now I see that it's deprecated... I guess we should switch over to nixfmt (nixfmt-rfc-style in nixpkgs), that seems like the most official one?

@powpingdone
Copy link
Contributor Author

@kuruczgy

What formatter?

alejandra

I have heard someone broke their speakers already.

Then what's the best way to contact the #aarch64-laptops IRC without exposing my IP? I've heard some mumbling about matrix but i'm not sure what to do or where to go for that.

@kuruczgy
Copy link
Owner

Then what's the best way to contact the #aarch64-laptops IRC without exposing my IP? I've heard some mumbling about matrix but i'm not sure what to do or where to go for that.

I mean you can use an IRC bouncer or a VPN or Tor.

Here is the Matrix link: https://matrix.to/#/#_oftc_#aarch64-laptops:matrix.org
Though Matrix isn't a very well engineered system either, and I have no idea if it's any better on the privacy front than IRC...

@powpingdone powpingdone force-pushed the try-audio branch 3 times, most recently from 1af0981 to 4b488f9 Compare November 21, 2024 22:36
@eureka-cpu
Copy link
Contributor

Maybe this will come in handy? hogliux/yoga7x-firmware@72b9daf

@kuruczgy
Copy link
Owner

kuruczgy commented Dec 3, 2024

Maybe this will come in handy? hogliux/yoga7x-firmware@72b9daf

AFAIU that's the file being compiled in audioreach-topology.nix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make speakers work
3 participants