-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some form of audio support #37
base: main
Are you sure you want to change the base?
Conversation
Sidenote: the way that I implemented this makes it so that it doesn't require package rebuilds. |
This is currently a draft due to speakersafetyd/unknown if speakers have hardware limiting. |
Cool, will test when I have time, thanks. How well is it working for you? Jos reported that "it will sound very distorted". Yeah, we should probably wait for a while before merging this, see if any work comes along on the speakersafetyd front. But if not, and otherwise it's working without issues for us, we could consider merging it behind an op-in enable flag along with a stern warning in the README about people being responsible for breaking their own speakers. |
It is definitely distorted, even to my not-audiophile ears. |
I guess we could put it behind a config flag. |
Also, I don't have my good recording equipment on me ATM so I can't replay a sample for you. |
Huh? https://psref.lenovo.com/Detail/Yoga_Slim_7_14Q8X9?M=83ED0001US
Does that mean it's already protected by hardware? @kuruczgy |
I have no idea... you might wanna ask about this in #aarch64-laptops, there are some more knowledgeable people there. But there is already one person with a Yoga Slim 7x there who seems to have broken their speakers, so until we have strong evidence that there is hardware protection and that person is having some other issue, I will assume there isn't. |
Also wanted to ask @powpingdone, what nix formatter are you using? I am using |
I mean you can use an IRC bouncer or a VPN or Tor. Here is the Matrix link: https://matrix.to/#/#_oftc_#aarch64-laptops:matrix.org |
1af0981
to
4b488f9
Compare
Maybe this will come in handy? hogliux/yoga7x-firmware@72b9daf |
AFAIU that's the file being compiled in |
4b488f9
to
70815a1
Compare
27b26f6
to
d1af492
Compare
d1af492
to
65fcbff
Compare
1406cb0
to
390d55c
Compare
Closes #31