Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make kubeadm init and join output the same error after failing to wait for control plane components #3149

Open
HirazawaUi opened this issue Jan 16, 2025 · 0 comments
Labels
area/cli kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Milestone

Comments

@HirazawaUi
Copy link
Contributor

Currently, during kubeadm init, if waiting for the control plane components to start fails, we output a templated error message.
Ref: https://github.com/kubernetes/kubernetes/blob/50fc400f178d2078d0ca46aee955ee26375fc437/cmd/kubeadm/app/cmd/phases/init/waitcontrolplane.go#L39-L58

However, during kubeadm join, if waiting for the control plane components to start fails, we output a raw error message.
Ref: https://github.com/kubernetes/kubernetes/blob/50fc400f178d2078d0ca46aee955ee26375fc437/cmd/kubeadm/app/cmd/phases/join/waitcontrolplane.go#L73-L77

We aim to ensure that kubeadm init and kubeadm join output the same error message format when waiting for the control plane components to start fails.

This can be implemented after the merge of kubernetes/kubernetes#129620.

@neolit123 neolit123 added priority/backlog Higher priority than priority/awaiting-more-evidence. kind/feature Categorizes issue or PR as related to a new feature. labels Jan 16, 2025
@neolit123 neolit123 added this to the v1.33 milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

2 participants