Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kinder: improve the no-addons workflow #3138

Merged
merged 1 commit into from
Jan 2, 2025
Merged

kinder: improve the no-addons workflow #3138

merged 1 commit into from
Jan 2, 2025

Conversation

neolit123
Copy link
Member

@neolit123 neolit123 commented Dec 28, 2024 •
edited
Loading

Add two more tasks in the workflow to account for the addition of 'disabled: true' fields in v1beta4:

  • Patch the ClusterConfiguration before upgrade to disable addons.
  • Make sure the addon ConfigMaps don't exist after upgrade.

xref

@neolit123
kinder: improve the no-addons workflow
c75f995 
Add two more tasks in the workflow to account for the addition of
'disabled: true' fields in v1beta4:
- Patch the ClusterConfiguration before upgrade to disable addons.
- Make sure the addon ConfigMaps don't exist after upgrade.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kinder Issues to track work in the kinder tool labels Dec 28, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 28, 2024
@neolit123
Copy link
Member Author

/hold
for

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 28, 2024
@neolit123 neolit123 added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 28, 2024
@neolit123 neolit123 mentioned this pull request Dec 28, 2024
Closed
@neolit123
Copy link
Member Author

neolit123 commented Dec 28, 2024 •
edited
Loading 

I1228 11:11:25.460914    1406 round_trippers.go:560] GET https://172.17.0.7:6443/api/v1/namespaces/kube-system/pods?labelSelector=component%3Dkube-apiserver 200 OK in 4 milliseconds
I1228 11:11:35.468462    1406 round_trippers.go:560] GET https://172.17.0.7:6443/apis/apps/v1/namespaces/kube-system/deployments?labelSelector=k8s-app%3Dkube-dns  in 10006 milliseconds
Get "https://172.17.0.7:6443/apis/apps/v1/namespaces/kube-system/deployments?labelSelector=k8s-app%3Dkube-dns": net/http: request canceled (Client.Timeout exceeded while awaiting headers)
couldn't retrieve DNS addon deployments
k8s.io/kubernetes/cmd/kubeadm/app/phases/addons/dns.deployedDNSReplicas
	k8s.io/kubernetes/cmd/kubeadm/app/phases/addons/dns/dns.go:77
k8s.io/kubernetes/cmd/kubeadm/app/phases/addons/dns.EnsureDNSAddon
	k8s.io/kubernetes/cmd/kubeadm/app/phases/addons/dns/dns.go:94
k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/upgrade.runCoreDNSAddon
	k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/upgrade/addons.go:104
k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/workflow.(*Runner).Run.func1
	k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/workflow/runner.go:261
k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/workflow.(*Runner).visitAll
	k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/workflow/runner.go:450
k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/workflow.(*Runner).Run
	k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/workflow/runner.go:234
k8s.io/kubernetes/cmd/kubeadm/app/cmd/upgrade.newCmdNode.func1
	k8s.io/kubernetes/cmd/kubeadm/app/cmd/upgrade/node.go:90
github.com/spf13/cobra.(*Command).execute
	github.com/spf13/[email protected]/command.go:985
github.com/spf13/cobra.(*Command).ExecuteC
	github.com/spf13/[email protected]/command.go:1117
github.com/spf13/cobra.(*Command).Execute
	github.com/spf13/[email protected]/command.go:1041
k8s.io/kubernetes/cmd/kubeadm/app.Run
	k8s.io/kubernetes/cmd/kubeadm/app/kubeadm.go:47
main.main
	k8s.io/kubernetes/cmd/kubeadm/kubeadm.go:25
runtime.main
	runtime/proc.go:272
runtime.goexit
	runtime/asm_amd64.s:1700
error execution phase addon/coredns
k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/workflow.(*Runner).Run.func1
	k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/workflow/runner.go:262
k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/workflow.(*Runner).visitAll
	k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/workflow/runner.go:450
k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/workflow.(*Runner).Run
	k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/workflow/runner.go:234
k8s.io/kubernetes/cmd/kubeadm/app/cmd/upgrade.newCmdNode.func1
	k8s.io/kubernetes/cmd/kubeadm/app/cmd/upgrade/node.go:90
github.com/spf13/cobra.(*Command).execute
	github.com/spf13/[email protected]/command.go:985
github.com/spf13/cobra.(*Command).ExecuteC
	github.com/spf13/[email protected]/command.go:1117
github.com/spf13/cobra.(*Command).Execute
	github.com/spf13/[email protected]/command.go:1041
k8s.io/kubernetes/cmd/kubeadm/app.Run
	k8s.io/kubernetes/cmd/kubeadm/app/kubeadm.go:47
main.main
	k8s.io/kubernetes/cmd/kubeadm/kubeadm.go:25
runtime.main
	runtime/proc.go:272
runtime.goexit
	runtime/asm_amd64.s:1700
Error: failed to exec action kubeadm-upgrade: exit status 1
 exit status 1

is that a flake?
https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubeadm/3138/pull-kubeadm-kinder-upgrade-latest/1872961457088368640

this presubmit job is not skipping the coredns addon. so it should be able to fetch the coredns deployment.

@neolit123
Copy link
Member Author

/retest

@pacoxu
Copy link
Member

pacoxu commented Dec 30, 2024 •
edited
Loading

is that a flake?
https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubeadm/3138/pull-kubeadm-kinder-upgrade-latest/1872961457088368640

A quick look shows that there are some etcd timeout errors in log, it may be caused by that kubeadm upgrade did not wait for etcd restarting in progress and it may flake once the etcd is restarting due to static pod yaml change, IIUC.

We may track it in an issue if it still flakes.

@pacoxu
Copy link
Member

pacoxu commented Jan 2, 2025

/hold for

/lgtm
Can we unhold now?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 2, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neolit123
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 2, 2025
@k8s-ci-robot k8s-ci-robot merged commit 37b699a into kubernetes:main Jan 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlory carlory Awaiting requested review from carlory

@SataQiu SataQiu Awaiting requested review from SataQiu

Assignees

@pacoxu pacoxu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kinder Issues to track work in the kinder tool cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neolit123 @pacoxu @k8s-ci-robot