Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResetConfiguration and UpgradeConfiguration API definition #3567

Closed
4 tasks
chendave opened this issue Sep 29, 2022 · 10 comments
Closed
4 tasks

ResetConfiguration and UpgradeConfiguration API definition #3567

chendave opened this issue Sep 29, 2022 · 10 comments
Assignees
Labels
sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.

Comments

@chendave
Copy link
Member

chendave commented Sep 29, 2022

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Sep 29, 2022
@chendave
Copy link
Member Author

/sig sig-cluster-lifecycle
/assgin

@k8s-ci-robot
Copy link
Contributor

@chendave: The label(s) sig/sig-cluster-lifecycle cannot be applied, because the repository doesn't have them.

In response to this:

/sig sig-cluster-lifecycle
/assgin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chendave
Copy link
Member Author

/sig cluster-lifecycle
/assign

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 29, 2022
@neolit123
Copy link
Member

@chendave we can use the existing issue / KEP:
#970

@chendave
Copy link
Member Author

chendave commented Sep 29, 2022

@neolit123 I am thinking how to re-use the existing KEP: https://github.com/kubernetes/enhancements/tree/master/keps/sig-cluster-lifecycle/kubeadm/970-kubeadm-config

That KEP is quite high level, consolidate what we have in this doc: https://docs.google.com/document/d/1R4zLtgDadNM8_N2VzS0DI2mADcYmkyJ3L7lJVpbyZsA looks a little weird, if we follow the style, we won't get much detail to discuss in the KEP.

How about create a separate a KEP and link that to the 970?

@neolit123
Copy link
Member

that is true, i guess.

so, historically we did not add struct / field details in the kubeadm config KEP and i think we should keep it that way.
if we are about to introduce v1beta4 we can just enumerate what changes are being made, similarly to how we did for v1beta3:
https://github.com/kubernetes/enhancements/tree/master/keps/sig-cluster-lifecycle/kubeadm/970-kubeadm-config#v1beta3

adding reset/upgrade config would be one of the chanegs.
details can remain in the google doc and k/kubeadm tracking issue.

@SataQiu @pacoxu WDYT?
i think we should close this and avoid having a new k/e issue / KEP.

@pacoxu
Copy link
Member

pacoxu commented Sep 29, 2022

A update to #970 would be OK.
So that we can know what changes in each version, like v1beta3\v1beta4.

Agree.

@chendave
Copy link
Member Author

I am fine with each one.

@chendave
Copy link
Member Author

details can remain in the google doc and k/kubeadm tracking issue.

+1

Let's continue to the discuss in the google doc, I will close this one until there is need to re-open this.

/close

@k8s-ci-robot
Copy link
Contributor

@chendave: Closing this issue.

In response to this:

details can remain in the google doc and k/kubeadm tracking issue.

+1

Let's continue to the discuss in the google doc, I will close this one until there is need to re-open this.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.
Projects
None yet
Development

No branches or pull requests

4 participants