Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use separate module names for the client-go and api pkgs from the operator implementation #283

Open
ahg-g opened this issue Dec 16, 2024 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@ahg-g
Copy link
Contributor

ahg-g commented Dec 16, 2024

What would you like to be added:

Allow developers to import the LWS api and client-go pkgs without the operator implementation.

Why is this needed:

In some cases, the dependencies that the operator brings with it are not compatible or not desirable with applications that would like to import lws api and client-go library only

See https://go.dev/doc/modules/managing-source

@ahg-g ahg-g added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 16, 2024
@kerthcet
Copy link
Contributor

@ahg-g
Copy link
Contributor Author

ahg-g commented Dec 18, 2024

One customer reported that they have an old controller-runtime dependency, and when they try to import lws, it causes conflicts. My assumption is that if we put sigs.k8s.io/lws/api/leaderworkerset/v1 and sigs.k8s.io/lws/client-go/applyconfiguration/leaderworkerset/v1 in a separate module, then that would resolve the conflict, wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants