Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the plugin to create a Helm Chart for Tutorials and Validate with them with GitHub action in the CI #4453

Open
camilamacedo86 opened this issue Dec 30, 2024 · 0 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. testing

Comments

@camilamacedo86
Copy link
Member

What do you want to happen?

Currently, we are just generating the helm chart for the sample: https://github.com/kubernetes-sigs/kubebuilder/tree/master/testdata/project-v4-with-plugins

The goal of this one is to generate the helm chart for the tutorial samples under:

  • docs/book/src/cronjob-tutorial/testdata/project
  • docs/book/src/getting-started/testdata/project
  • docs/book/src/multiversion-tutorial/testdata/project

Therefore:

  • We need a new GitHub Action named test-helm-book such as the existing CI workflow for Helm sample testing as a guide: test-helm-samples.yml.
  • We need to modify the hack logic to call the chart as well. Reference the existing structure and commands in hack.
  • The existing target in the Makefile to allow generating only the Helm charts see Makefile Helm Target need also be updated so that when we run make generate-charts we will do for both sample under testdata and docs

Extra Labels

No response

@camilamacedo86 camilamacedo86 added kind/feature Categorizes issue or PR as related to a new feature. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. testing kind/documentation Categorizes issue or PR as related to documentation. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. testing
Projects
None yet
Development

No branches or pull requests

1 participant