Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance v1 NodeClaim print output to show drifted state #1464

Open
cnmcavoy opened this issue Jul 24, 2024 · 4 comments · May be fixed by #1846
Open

Enhance v1 NodeClaim print output to show drifted state #1464

cnmcavoy opened this issue Jul 24, 2024 · 4 comments · May be fixed by #1846
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@cnmcavoy
Copy link
Contributor

Description

What problem are you trying to solve?
As a cluster admin, when I am deploying changes to nodeclaims, or nodeclasses, it is hard to view how many nodeclaims have drifted. There are Prometheus metrics, but I am not aware of a way get the nodeclaim status without jq magic from the cli. Karpenter should show the nodeclaim drifted state in the wide output.

How important is this feature to you?
This feature would make it easier to track the progress of nodepool changes and upgrades, when nodes are being replaced with drift.

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@cnmcavoy cnmcavoy added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 24, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jul 24, 2024
@njtran
Copy link
Contributor

njtran commented Jul 25, 2024 •
edited
Loading

This seems pretty reasonable to me. @jonathan-innis have you thought about this before? I see a similar issue (albeit a different request) #1152

@njtran
Copy link
Contributor

njtran commented Jul 25, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 25, 2024
@jonathan-innis
Copy link
Member

jonathan-innis commented Aug 12, 2024 •
edited
Loading

Karpenter should show the nodeclaim drifted state in the wide output

Makes sense to me. We've thought about marking the NodePool as "Progressing" or something similar to how Deployment has a "Progressing" condition to say that the pods are being actively rolled.

@cnmcavoy Are you just interested in knowing that the NodePool is drifted or you are interested in knowing more info like the number of drifted nodes?

@leif013
Copy link

leif013 commented Sep 4, 2024

@jonathan-innis I think we're interested in making it simpler to see which specific nodes are currently in drift (without jq as listed in the initial post). The metrics are sufficient for raw counts.

@cnmcavoy cnmcavoy linked a pull request Nov 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Expose drifted nodeclaim condition status to printer column output cnmcavoy/karpenter
5 participants
@leif013 @njtran @cnmcavoy @k8s-ci-robot @jonathan-innis