-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve release notes readability #3925
Comments
Thank you for opening this @mloiseleur. I would love to offer my point of view: the unit of work on github is a pull request, not a commit. I know this is not conventional git, but it's in practice how people work here. In my experience, as much as we can try to enforce rules on how commits are written or structured, they are often just used as ways to run CI, save half baked unit of work, iterate on things... For bigger chunks of works, it gets hard to keep the commit history really well structured and asking to do so is often a barrier to contribution. That said, in general I'm not opposed to trying things out and see what we learn. I would prefer if we try proposing rules for the PR title: that would fit our release notes right away and would be easy to lint via a GitHub action. The same can or should apply to PR descriptions in case of breaking changes. Happy to hear your thoughts. |
Yes, conventional commits on the commits inside the PRs are clearly a barrier to contribution. => I agree with you, @Raffo, conventional commits in this project would means, in practice, to try, doc and lint on PR title. |
I like the approach that kops takes: keep a Markdown file for collecting the notes for the next release. Only a limited subset of the PRs warrant a mention in the notes and most of those that do require more than the PR title. The idea is to build them as we go, not require a massive editing job at release time. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close not-planned |
@k8s-triage-robot: Closing this issue, marking it as "Not Planned". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Context
=> And so, changelog is quite hard to read. In latest release, v0.13.6, 78 PRs has been merged.
In the past, there were a changelog file. It was removed, see #1754
Current github action used for release, release-drafter/release-drafter, allows to produce better changelog by configuring and using labels on each PRs. It's not configured and used on
external-dns
Edit: It seems they plan to support conventional commit it for the next breaking release.
Proposal
Improve changelog readability by using conventions.
Nowadays, there is a convention about commits.
Those conventional commits improves git history readability and allows to produce changelog based on PR title.
This convention is already suggested by some contributors on this repo who opens their PRs following conventional commit spec.
Latest release, v0.13.6, contains 30/78 PRs following this conventions (~38,5%) without any linter or doc about it.
external-dns
could adopt conventional commits, enforce it by adding a needed check before merge on it and use a github action aware of this convention (like ncipollo/release-action or requarks/changelog-action) to generate a more readable changelog when releasing a new version.The text was updated successfully, but these errors were encountered: