Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we run tests which are runnable? #7

Open
utkarsh2102 opened this issue Apr 26, 2021 · 1 comment
Open

Can we run tests which are runnable? #7

utkarsh2102 opened this issue Apr 26, 2021 · 1 comment

Comments

@utkarsh2102
Copy link

Hello,

I see tests are disabled:

export PYBUILD_DISABLE=test

And also there are test failures; see: keylime/keylime#641.

That said, does it make sense to run tests which can be run? I know we ought to disable some of them for sure but maybe that's worth doing since it'd enable a few? Let me know what you think?

@galmasi
Copy link
Contributor

galmasi commented May 4, 2021

I have not considered this. Please feel free to add runnable unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants