Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BreweryX fires way too many triggers #388

Open
4 of 6 tasks
AverageDood opened this issue Dec 24, 2024 · 9 comments
Open
4 of 6 tasks

BreweryX fires way too many triggers #388

AverageDood opened this issue Dec 24, 2024 · 9 comments
Labels
S-confirmed State: This issue has been replicated correctly T-bug Type: Something isn't working

Comments

@AverageDood
Copy link

Basic questions:

  • I am actually using ketting, and not any other software (e.g. magma)
  • I am using the latest Ketting version at the time of writing for the Minecraft version, that I am using
  • I have provided full server logs and not a crash-report
  • I have checked all items without reading.
  • I have provided proper reproduction steps
  • I have ticked all boxes

What Minecraft Version is your Server on?

1.20.1

Full Ketting Version

1.20.1-47.3.12-0.3.31

Description of behavior

Part 2 of #383, after the update that fixed the triggers not firing. Now, instead of not firing, it fires countless of them. The triggers fired are the right ones per each drink, applying the correct status effects and everything, but it doesn't seem to know where to stop. It eventually stops, but I'm guessing is on some kind of timeout.

Once again, a video on the additional notes showing the behaviour.

Reproduction Steps

Steps to reproduce the behavior:
1. Use above Version with plugin BreweryX latest
2. Run the server
3. Create a BreweryX drink
4. Drink it, see how it just fires off like Jinx on a bad day

Logs

debug.log
latest.log

Additional context

Oops.mp4

@AverageDood AverageDood added the T-bug Type: Something isn't working label Dec 24, 2024
@JustRed23
Copy link
Member

That definitely is an interesting one, that one didn't happen when I was testing the plugin, I'll do some testing later

@AverageDood
Copy link
Author

I noticed mclo.gs had a line limit, so this time I uploaded the logs to my own Nextcloud server. If you need anything, let me know and I'll check for it

@JustRed23
Copy link
Member

Seems like I cannot reproduce this one, I tried it with /brew create &6Golden Vodka, drank one and it only increased by a little amount. Do you have any other mods or plugins that I need to know of to be able to reproduce this?

@JustRed23 JustRed23 added the S-can't reproduce State: The issue could not be reproduced. More detailed/Better reproduction steps are nessesary. label Dec 29, 2024
@AverageDood
Copy link
Author

We absolutely do, but the mod amount is... Big to say the least. We may have pushed the hybrid to its limits.

Just came back from a trip, give me a few to settle and talk with my other server admin. I'll give you the full list. I'd give you exactly what conflicts instead of the whole thing, but frankly, I have no idea what conflicts

@JustRed23
Copy link
Member

Before doing all of that, make sure that you do not have any optimization mods installed, they tend to introduce weirdness into hybrids, things like canary or basically anything with 'fix' in the name should go

@AverageDood
Copy link
Author

Sorry about the delay. As I said, is a massive list, so I'll be linking you a folder with 2 zip files, with the one for plugins and another for mods. No server optimization mods, all game optimization is done on the client side. Is a total of 108 forge mods and 30 plugins.

Nextcloud folder with the stuff

As I said, we pushed it to the limits.
Please don't hate us

@JustRed23
Copy link
Member

Seems like I did actually reproduce it without all the mods, but this only seems to happen in creative mode

@JustRed23 JustRed23 removed the S-can't reproduce State: The issue could not be reproduced. More detailed/Better reproduction steps are nessesary. label Jan 1, 2025
@JustRed23
Copy link
Member

Yep confirmed to be reproducible in creative mode only

@JustRed23 JustRed23 added the S-confirmed State: This issue has been replicated correctly label Jan 1, 2025
@AverageDood
Copy link
Author

I gotta congratulate you and the whole Ketting team. All the content we have thrown at it on both the Spigot and the Forge sides, and this on BreweryX was the only thing we've hit ourselves against. Project maybe a WIP, but the hybrid is rock solid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-confirmed State: This issue has been replicated correctly T-bug Type: Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants