Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix the navigation to Keptn v1 Docs #2676

Merged
merged 2 commits into from
Dec 18, 2023
Merged

docs: fix the navigation to Keptn v1 Docs #2676

merged 2 commits into from
Dec 18, 2023

Conversation

sambhavgupta0705
Copy link
Member

Description

fixed the navigation of keptn v1 on the home page

Fixes #2620

@sambhavgupta0705 sambhavgupta0705 requested review from a team as code owners December 14, 2023 18:56
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 14, 2023
@netlify Netlify
Copy link

netlify bot commented Dec 14, 2023 •
edited
Loading

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit bcb5bb3
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6580277d485fa400072e3ba9
😎 Deploy Preview https://deploy-preview-2676--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sambhavgupta0705
Copy link
Member Author

@mowies I have fixed the issue as desired but one of the check is failing

@agardnerIT
Copy link
Contributor

Screenshot 2023-12-16 at 9 24 08 am

I don't know if it was introduced during this PR or another one, but I'm seeing a Page Not Found hyperlink on the deploy preview.

@sambhavgupta0705
Copy link
Member Author

Screenshot 2023-12-16 at 9 24 08 am I don't know if it was introduced during this PR or another one, but I'm seeing a `Page Not Found` hyperlink on the deploy preview.

@agardnerIT I saw other PR preview and it is in them also

@mowies
Copy link
Member

mowies commented Dec 18, 2023

@sambhavgupta0705 @agardnerIT that's normal and has been like this since ages. It's only on the preview, not on the live page.

@mowies
Copy link
Member

mowies commented Dec 18, 2023

The failing readthedocs check is fine here. That's the deploy preview for the new docs page which is missing the new page config in this PR. Don't worry about it :)

@mowies mowies changed the title fix: fixed the naviagtion of keptn v1 fix: fix the navigation to Keptn v1 Docs Dec 18, 2023
@mowies mowies changed the title fix: fix the navigation to Keptn v1 Docs docs: fix the navigation to Keptn v1 Docs Dec 18, 2023
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mowies
Copy link
Member

mowies commented Dec 18, 2023

@sambhavgupta0705 Thanks for the contribution! 🎉

@mowies mowies merged commit 14b1adf into keptn:main Dec 18, 2023
10 checks passed
mowies pushed a commit to mowies/lifecycle-controller that referenced this pull request Dec 18, 2023
@sambhavgupta0705 @mowies
docs: fix the navigation to Keptn v1 Docs (keptn#2676)
062a720 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies mowies mentioned this pull request Dec 18, 2023
Merged
@keptn-bot keptn-bot mentioned this pull request Jan 23, 2024
Merged
@sambhavgupta0705 sambhavgupta0705 mentioned this pull request Jan 29, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mowies mowies mowies approved these changes

@bacherfl bacherfl bacherfl approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keptn v1 docs no longer available
4 participants
@sambhavgupta0705 @agardnerIT @mowies @bacherfl