test(rust-rpc-test): have a contract to declare which is not already declared

[tdelabro]

during the genesis phase of the sharingan test-chains, we populate the state with a few contracts already declared and deployed.

One of them is ERC20.json. Due to some shenanigans, it was declared with another arbitrary class hash, making it possible for users to re-declare it a second time, this time with it's real class hash.

Some tests used this contract in order to test the declare workflow starknet-rpc-test::get_transaction_receipt:: work_with_declare_transaction is a survivant of this era that we are ignoring for now.

One should activate this test again by making it declare another contract class, one which is not already present in the storage

[NaitikChaudhary]

Can I take this one?

[apoorvsadana]

Assigned to you!

[tdelabro]

Hey, all good?
We can unassign you if you can't find time. No big deal

[NaitikChaudhary]

Hey, last few weeks were really hectic for me couldn’t take out time, but this week I can take out time for sure, so is it fine if I create a PR by this weekend?

…

On Thu, 12 Oct 2023 at 3:48 PM, Timothée Delabrouille < ***@***.***> wrote: Hey, all good? We can unassign you if you can't find time. No big deal — Reply to this email directly, view it on GitHub <#1110 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANDC2FGCKY4VTLMNSBQCNDTX667XPANCNFSM6AAAAAA44WK3SA> . You are receiving this because you were assigned.Message ID: ***@***.***>

[tdelabro]

Yeah sure.
2 ways you can do it.

• group all the tests regarding declare in one single tests and do all the checks after a single declare
• create n contracts with one internal constant ranging from 0 to n. Then use one of them in each test that need to call declare

[tdelabro]

Also, check #1145 I flag all tests using declare as ignored because they were all redeploying the same contract.
You will have to un-ignore them in your PR

[tdelabro]

@NaitikChaudhary All good?

[tdelabro]

@NaitikChaudhary Will you deliver this one or can I unassign it from you?

[apoorvsadana]

I don't think he's working on it. Unassigned him.

[edisontim]

Hey, can I take this :) ?

[tdelabro]

@edisontim everything for my fellow 42 alumni

[edisontim]

Thanks! On it :)

[edisontim]

Yeah sure. 2 ways you can do it.

• group all the tests regarding declare in one single tests and do all the checks after a single declare
• create n contracts with one internal constant ranging from 0 to n. Then use one of them in each test that need to call declare

Contract being declared in starknet-rpc-test::get_transaction_receipt:: work_with_declare_transaction is Counter.json, so this is the contract that can't be redeclared multiple times right?

I think I'll go first the first solution, this seems the cleanest now. However, if more declare tests need to happen this could get messy

[tdelabro]

Yes that is the one.

I think first option is okay. Yes you will have to organize and comment your code correctly so it don't get nightmarish

[edisontim]

Had a look at a global variable shared between all tokio tests or a single use init function that launched before tests but wasn't able to find anything viable :/

[tdelabro]

Wdym?
You have to run your node manually and then launch the test.

[edisontim]

I mean having a setup function before all rpc-tests that would declare the contract once for all tests and make available a global declare_tx variable, but it seems like with async tests that's impossible

[tdelabro]

Yep, there is no init logic in cargo test. I would not rely on this behavior.
What you can do is create a function declare_if_not_already() { if already_declared {} else { declare() } } and call it in all your tests that need this contract deployed. A bit hacky but it solve you problem

[edisontim]

Yeah I'm having a look at that now, it's cleaner than having n contracts declared imo