Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slashdash node doesn't accept semicolon terminator #107

Open
eugenesvk opened this issue Dec 24, 2024 · 2 comments
Open

Slashdash node doesn't accept semicolon terminator #107

eugenesvk opened this issue Dec 24, 2024 · 2 comments
Labels
needs more info More information is needed before work can continue

Comments

@eugenesvk
Copy link

Slash-dashed simple node fails with ; terminator, though couldn't find anything in the spec changes to warrant that (py/js parsers parse this fine)

With kdl-rs 6.1.0

/-n 1;
  × Failed to parse KDL document

Error:
  × Found invalid node name
   ╭────
 1 │ /-n 1;
   ·      ┬
   ·      ╰── not node name
   ╰────
  help: This can be any string type, including a quoted, raw, or multiline string, as well as a plain identifier string.
@zkat
Copy link
Member

zkat commented Dec 24, 2024

Haha no that’s definitely a bug. Thanks for the report

@zkat
Copy link
Member

zkat commented Jan 1, 2025

uhhh, so this test passes: assert!(document.parse(new_input("/-n 1;")).is_ok());

are you seeing this as part of a larger doc? Is this really the minimal repro?

@zkat zkat added the needs more info More information is needed before work can continue label Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs more info More information is needed before work can continue
Projects
None yet
Development

No branches or pull requests

2 participants