Error in if (nrow(output) == 1000) when using DEM_request()

[Nowosad]

library(rgugik)
library(sf)
#> Linking to GEOS 3.12.2, GDAL 3.8.5, PROJ 9.3.1; sf_use_s2() is TRUE
polygon_path = system.file("datasets/search_area.gpkg", package = "rgugik")
polygon = read_sf(polygon_path)
req_df = DEM_request(polygon)
#> Error in if (nrow(output) == 1000) {: argument is of length zero

The issue seems to origin here --

rgugik/R/DEM_request.R

Line 96 in d6b7472

output = tryGet(jsonlite::fromJSON(prepared_URL))

@kadyb are you aware of any changes to the geoportal that could cause this problem?

[kadyb]

Thanks for the information, I haven't looked into this yet. The server returns HTTP Error 400 (Bad Request), so something in the API has changed. ortho_request() doesn't work either.

[kadyb]

It should work now. Dev version can be installed with:

# install.packages("remotes")
remotes::install_github("kadyb/rgugik")

One more issue is not resolved (but it worked before). In the case of ortho_request() the resolution is returned, which should be floating point (in the database it is a single datatype). However, now the values ​​returned are 0 or 1 (integer). Maybe it is because comma is used and there should be a dot (or vice versa) and the decimal part is simply removed. The same applies to the avgElevErr attribute in DEM_request().

[kadyb]

Referring to my previous comment, this will probably not be fixed. I have reported this several times and each time I get negative response as it doesn't apply to the core of Geoportal. Therefore, these two attributes resolution in ortho_request() and avgElevErr in DEM_request() will be incorrect (although it worked fine for several years).

[kadyb]

It looks like they updated the services again and nothing works again.

[kadyb]

It should work now. The resolution and avgElevErr attributes were also fixed upstream by GUGiK thankfully.

[Nowosad]

Great work, @kadyb