You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the placeholder/blank content for the extension is not styled in the same way as the Table of Contents, something relevant now because of other related efforts going on:
Also, the placeholder title is Sentence cased, not Title Cased.
Proposed Solution
Adapt the markup of the placeholder/blank content, as well as the respective styles, so that this content is similar to the Table of Contents placeholder one:
These changes involve, from my perspective, updating padding, margins, text alignment, and text color. Additionally, slightly adapt the markup (by changing the placeholder text from <div> to <p> and adding placeholder-related CSS classes), as well as convert the title to Title Case.
Hi! 👋
Problem
Currently, the placeholder/blank content for the extension is not styled in the same way as the Table of Contents, something relevant now because of other related efforts going on:
Also, the placeholder title is Sentence cased, not Title Cased.
Proposed Solution
Adapt the markup of the placeholder/blank content, as well as the respective styles, so that this content is similar to the Table of Contents placeholder one:
jupyter-resource-usage/packages/labextension/src/widget.tsx
Lines 250 to 263 in 6f15ef9
jupyter-resource-usage/packages/labextension/style/base.css
Lines 10 to 27 in 6f15ef9
These changes involve, from my perspective, updating padding, margins, text alignment, and text color. Additionally, slightly adapt the markup (by changing the placeholder text from
<div>
to<p>
and adding placeholder-related CSS classes), as well as convert the title to Title Case.Current Workaround
Additional context
Let me know what you think and if I can open a PR. Thanks!
The text was updated successfully, but these errors were encountered: