Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot import project into PayForMe due to uppercase letters in project share token #327

Open
saemy opened this issue Jan 5, 2025 · 0 comments · May be fixed by #329
Open

Cannot import project into PayForMe due to uppercase letters in project share token #327

saemy opened this issue Jan 5, 2025 · 0 comments · May be fixed by #329

Comments

@saemy
Copy link

saemy commented Jan 5, 2025

Adding a cospend project into PayForMe is no longer possible as it fails with an error.
I know, this sounds like a problem of the PayForMe iOS app - and it is! (see mayflower/PayForMe#68). However, that app is not maintained for the foreseeable future (mayflower/PayForMe#68 (comment)).

The issue is that the app always converts the share token of a cospend project to lowercase. This worked before this commit 4f08f66#diff-5eade415ee9f2d23606951e0a1fec457918fb1e64c65f7cf27dc947a04ff0699L3540, where md5() was used and always produced lowercase share tokens. But now ISecureRandom::generate() is used which also produces uppercase letters.

Is it possible to always generate a lowercase-only project share token in order to keep PayForMe compatible?
Thank you very much!
saemy added a commit to saemy/cospend-nc that referenced this issue Jan 5, 2025
@saemy
Don't use uppercase letters in project share token
7441076 
To remain compatible with PayForMe, which requires lowercase project share
tokens, only use lowercase chars and digits in project shares.

Fixes julien-nc#327
See also mayflower/PayForMe#68
@saemy saemy linked a pull request Jan 5, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't use uppercase letters in project share token saemy/cospend-nc
1 participant
@saemy