Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize setup #47

Open
NobbZ opened this issue Mar 26, 2016 · 7 comments
Open

Reorganize setup #47

NobbZ opened this issue Mar 26, 2016 · 7 comments

Comments

@NobbZ
Copy link
Contributor

NobbZ commented Mar 26, 2016

Reorganize the setup of everything such that it is much easier to begin with everything.

I struggled a lot during the setup phase, and I'm still unsure if everything is working as it should. Probably either the documentation or the workflow itself should be updated in a way that makes the process more clear for potential contributors.

@juditacs
Copy link
Owner

Are you talking about the README or the framework itself? So far others haven't reported serious difficulties.
https://github.com/juditacs/wordcount#adding-a-new-program

@NobbZ
Copy link
Contributor Author

NobbZ commented Mar 26, 2016

As already mentioned in #44 I had a hard time to get the right set of data into the docker VM, also, even after using scripts/build.sh nothing works.

Only a couple of things have an ok when running scripts/test_all.sh.

The scripts/compare.sh does have an error for half of the programms, too, and I have no idea of how to fix them.

@NobbZ
Copy link
Contributor Author

NobbZ commented Mar 26, 2016

OK, I messed everything up ;) for some reason I had the zipped file in data and realized this very late.

So it is completely my fault, but at least you should consider to share the folders instead of cloning inside the container and officially add that to the README.

@juditacs
Copy link
Owner

Which folder?
I don't think it's a good idea to have a shared folder and to maintain it.

I'll try to clear up the README.

@NobbZ
Copy link
Contributor Author

NobbZ commented Mar 26, 2016

I'm used to vagrant, where I have a folder which is shared between host and
guest machine. There I'm able to edit using the toolset available at the
host, while running tests etc in the guest.

The way you have setup the container means that I need to push changes I
made using tools/editors on the host to a central repository first, then I
need to pull, and even resolve merge conflicts when I'm out of luck. Using
a shared folder is much less PIA than having them unshaped.

The folder I'm talking about is /wordcount, which is below / and not below
/root as written in the README.

Judit Acs [email protected] schrieb am Sa., 26. März 2016 20:21:

Which folder?
I don't think it's a good idea to have a shared folder and to maintain it.

I'll try to clear up the README.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#47 (comment)

@juditacs
Copy link
Owner

Others noted that it's possible to share a folder on the host machine with docker. This stackoverflow post has some examples.

I'm a VIM user so this is not really an issue for me. I've never used vagrant, the website is kind of vague but it sounds interesting.

Thanks for notifying me about that error in the README (more like in the Dockerfile).

@svanoort
Copy link
Contributor

@NobbZ This is pretty easy to set up with the docker file and a workdir. I'll take it on along with #54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants