Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test results should be immutable if not in-progress #600

Open
MartinKolarik opened this issue Jan 18, 2025 · 0 comments
Open

Test results should be immutable if not in-progress #600

MartinKolarik opened this issue Jan 18, 2025 · 0 comments
Assignees

Comments

@MartinKolarik
Copy link
Member

I've run into a weird case where a test was marked as a timeout, but a second later, the timeout message was overwritten with the results. Setting aside the fact that the probe shouldn't have taken 32 seconds to report the results, the API should still prevent this as it is confusing and contradicts our documentation.

We already have a check here, but when a test is marked as a timeout, we don't seem to increment probesAwaiting. Additionally, there's no check when calling recordProgress(), I think we should use a lua script with a check there as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants