Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytical Jacobian Sanity Check #3

Open
MFMorrell opened this issue Jun 12, 2014 · 2 comments
Open

Analytical Jacobian Sanity Check #3

MFMorrell opened this issue Jun 12, 2014 · 2 comments

Comments

@MFMorrell
Copy link

The sanity check in ProblemDefinition.py on lines 397, 402, 421 for the analytical jacobian and lines 464, 468 , 472, 476, 501 and 505 for boundary derivative should be relative not absolute error.

@jsalvatier
Copy link
Owner

Have you experienced a problem with this?

@MFMorrell
Copy link
Author

I had a problem in some stellar structure code. This no longer causes a problem with scaled variables. Something like dx/dt=1e50* polygamma(0,x) and the corresponding Jacobian entry of 1e50*polygamma(1,x) will cause this to happen however.

I've uploaded a version the fixes the problem. Note that you may want to suppress the NaN warning for 0 Jacobian entries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants