Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dark mode possible #881

Open
jesus2099 opened this issue Dec 23, 2024 · 0 comments
Open

Make dark mode possible #881

jesus2099 opened this issue Dec 23, 2024 · 0 comments

Comments

@jesus2099
Copy link
Owner

jesus2099 commented Dec 23, 2024

I should use classes for TAG_LINKS instead of inline styles, everywhere.

Aszazin:

Is it possible to add a class to the div element for the tags in the sidebar that says “:arrow_lower_left:mine and others’” ?

Reason is I am not able to adjust that part to my dark mode without risking unexpected side effects.
(It’s on line 1280 of your code)

tagZone.parentNode.insertBefore(createTag("div", {s: {position: "relative", bottom: "-1rem", color: "black", fontWeight: "normal", "float": "right"}}, ["↙", createTag("span", {s: {backgroundColor: "#B1EBB0"}}, "mine"), " and others’"]), tagZone.previousSibling);

kellnerd:

Yeah, that would be nice. Even better would be to avoid inline styles in HTML altogether.

Currently I have to resort to a very ugly hack to work around that

I will probably limit this ticket to TAG_LINKS, otherwise I will never have time to fix it globally, without other reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant